Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h

Issue 2620783002: [sync] Handle local changes in AutocompleteSyncBridge (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
index 962985897c4aa1597b23b279ccafcfb163e318df..cd350bec3228bb71be9ed13ce486dc2c8a6d2164 100644
--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
@@ -42,7 +42,7 @@ class AutocompleteSyncBridge : public base::SupportsUserData::Data,
static AutocompleteSyncBridge* FromWebDataService(
AutofillWebDataService* web_data_service);
- // syncer::ModelTypeService implementation.
+ // syncer::ModelTypeSyncBridge implementation.
std::unique_ptr<syncer::MetadataChangeList> CreateMetadataChangeList()
override;
base::Optional<syncer::ModelError> MergeSyncData(
@@ -70,11 +70,13 @@ class AutocompleteSyncBridge : public base::SupportsUserData::Data,
// Returns the table associated with the |web_data_backend_|.
AutofillTable* GetAutofillTable() const;
- std::string GetStorageKeyFromAutofillEntry(
- const autofill::AutofillEntry& entry);
+ // Respond to local autofill entries changing by notifying sync of the
+ // changes.
+ void ActOnLocalChanges(const AutofillChangeList& changes);
- static std::string FormatStorageKey(const std::string& name,
- const std::string& value);
+ // Synchronously load sync metadata from the autofill table and pass it to the
+ // processor so that it can start tracking changes.
+ void LoadMetadata();
base::ThreadChecker thread_checker_;
« no previous file with comments | « no previous file | components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698