Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h

Issue 2620783002: [sync] Handle local changes in AutocompleteSyncBridge (Closed)
Patch Set: rebase onto sky's changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
index 962985897c4aa1597b23b279ccafcfb163e318df..24860bb010381f6989caf13b9f63290abdfdb90a 100644
--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
@@ -42,7 +42,7 @@ class AutocompleteSyncBridge : public base::SupportsUserData::Data,
static AutocompleteSyncBridge* FromWebDataService(
AutofillWebDataService* web_data_service);
- // syncer::ModelTypeService implementation.
+ // syncer::ModelTypeSyncBridge implementation.
std::unique_ptr<syncer::MetadataChangeList> CreateMetadataChangeList()
override;
base::Optional<syncer::ModelError> MergeSyncData(
@@ -70,11 +70,11 @@ class AutocompleteSyncBridge : public base::SupportsUserData::Data,
// Returns the table associated with the |web_data_backend_|.
AutofillTable* GetAutofillTable() const;
- std::string GetStorageKeyFromAutofillEntry(
- const autofill::AutofillEntry& entry);
+ // Respond to local autofill entries changing by notifying sync of the
+ // changes.
+ void ActOnLocalChanges(const AutofillChangeList& changes);
- static std::string FormatStorageKey(const std::string& name,
- const std::string& value);
+ void LoadMetadata();
Patrick Noland 2017/01/13 23:31:53 I'll add a comment for this function.
Patrick Noland 2017/01/17 22:59:55 Done.
base::ThreadChecker thread_checker_;

Powered by Google App Engine
This is Rietveld 408576698