components/sync/model/model_type_sync_bridge.cc - Issue 2620773002: [Sync] Use ModelError all the way through to ModelTypeController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/model_type_sync_bridge.cc

Issue 2620773002: [Sync] Use ModelError all the way through to ModelTypeController. (Closed)

Patch Set: const& everything and use a typedef. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/model_type_sync_bridge.cc

diff --git a/components/sync/model/model_type_sync_bridge.cc b/components/sync/model/model_type_sync_bridge.cc

index ca6d733b7537c5159fac2dfd4e390e67488caed5..c6954286d40efffc24eea635cb5e4c661a112dd8 100644

--- a/components/sync/model/model_type_sync_bridge.cc

+++ b/components/sync/model/model_type_sync_bridge.cc

@@ -31,7 +31,7 @@ ConflictResolution ModelTypeSyncBridge::ResolveConflict(

}

void ModelTypeSyncBridge::OnSyncStarting(

- std::unique_ptr<DataTypeErrorHandler> error_handler,

+ const ModelErrorHandler& error_handler,

const ModelTypeChangeProcessor::StartCallback& start_callback) {

change_processor_->OnSyncStarting(std::move(error_handler), start_callback);

}