Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: media/capture/video/video_capture_buffer_tracker.h

Issue 2620763003: Reland [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct (Closed)
Patch Set: Let Buffer::HandleProvider provide a handle for legacy IPC instead of requiring wrapping/unwrapping. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_buffer_tracker.h
diff --git a/media/capture/video/video_capture_buffer_tracker.h b/media/capture/video/video_capture_buffer_tracker.h
index 3e3d7bf888a2ff37aacdd53963c80476ea1f3c98..7ef13ecfc490a67c12103a974ad84f3473e78c76 100644
--- a/media/capture/video/video_capture_buffer_tracker.h
+++ b/media/capture/video/video_capture_buffer_tracker.h
@@ -50,10 +50,10 @@ class CAPTURE_EXPORT VideoCaptureBufferTracker {
void set_frame_feedback_id(int value) { frame_feedback_id_ = value; }
int frame_feedback_id() { return frame_feedback_id_; }
- // Returns a scoped handle to the underlying storage.
- virtual std::unique_ptr<VideoCaptureBufferHandle> GetBufferHandle() = 0;
-
+ virtual std::unique_ptr<VideoCaptureBufferHandle> GetMemoryMappedAccess() = 0;
virtual mojo::ScopedSharedBufferHandle GetHandleForTransit() = 0;
+ virtual base::SharedMemoryHandle
+ GetNonOwnedSharedMemoryHandleForLegacyIPC() = 0;
miu 2017/01/13 20:34:38 If you haven't, consider running `git cl format`.
chfremer 2017/01/17 23:35:58 Tried, but seems the auto-formatting tool wants it
private:
// |dimensions_| may change as a VideoCaptureBufferTracker is re-used, but

Powered by Google App Engine
This is Rietveld 408576698