media/capture/video/video_capture_buffer_pool_impl.h - Issue 2620763003: Reland [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/video_capture_buffer_pool_impl.h

Issue 2620763003: Reland [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct (Closed)

Patch Set: Let Buffer::HandleProvider provide a handle for legacy IPC instead of requiring wrapping/unwrapping. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/video_capture_buffer_pool_impl.h

diff --git a/media/capture/video/video_capture_buffer_pool_impl.h b/media/capture/video/video_capture_buffer_pool_impl.h

index 08c84750c2dfa882c67c18db6736064a9090aecd..b5073df7d742ce986effddcfb35ddfce42050e91 100644

--- a/media/capture/video/video_capture_buffer_pool_impl.h

+++ b/media/capture/video/video_capture_buffer_pool_impl.h

@@ -35,8 +35,11 @@ class CAPTURE_EXPORT VideoCaptureBufferPoolImpl

int count);

// VideoCaptureBufferPool implementation.

- mojo::ScopedSharedBufferHandle GetHandleForTransit(int buffer_id) override;

- std::unique_ptr<VideoCaptureBufferHandle> GetBufferHandle(

+ mojo::ScopedSharedBufferHandle GetHandleForInterProcessTransit(

+ int buffer_id) override;

+ base::SharedMemoryHandle GetNonOwnedSharedMemoryHandleForLegacyIPC(

+ int buffer_id) override;

+ std::unique_ptr<VideoCaptureBufferHandle> GetHandleForInProcessAccess(

int buffer_id) override;

int ReserveForProducer(const gfx::Size& dimensions,

media::VideoPixelFormat format,