[TypeFeedbackVector] Root literal arrays in function literals slots

src/objects-printer.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <iomanip>
 #include <memory>
 
 #include "src/bootstrapper.h"
@@ skipping 790 matching lines @@
         break;
       }
       case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC: {
         CompareICNexus nexus(this, slot);
         os << Code::ICState2String(nexus.StateFromFeedback());
         break;
       }
       case FeedbackVectorSlotKind::STORE_DATA_PROPERTY_IN_LITERAL_IC: {
         StoreDataPropertyInLiteralICNexus nexus(this, slot);
         os << Code::ICState2String(nexus.StateFromFeedback());
-        break;

[Michael Starzinger, 2017/01/11 12:07:27]

Looks like accidental deletion. I think this is a real bug.

[mvstanton, 2017/01/11 13:14:52]

yowza, thanks!

       }
       case FeedbackVectorSlotKind::CREATE_CLOSURE: {
         // TODO(mvstanton): Integrate this into the iterator.
         int parameter_value = metadata()->GetParameter(parameter_index++);
         os << "[" << parameter_value << "]";
         break;
       }
       case FeedbackVectorSlotKind::GENERAL:
         break;
       case FeedbackVectorSlotKind::INVALID:
@@ skipping 880 matching lines @@
     printf("Not a transition array\n");
   } else {
     reinterpret_cast<i::TransitionArray*>(object)->Print();
   }
 }
 
 extern void _v8_internal_Print_StackTrace() {
   i::Isolate* isolate = i::Isolate::Current();
   isolate->PrintStack(stdout);
 }