Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

Issue 2620743002: Don't throttle web views until they've been in the background for 10s (Closed)
Patch Set: Fix asan test issue Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
index 60eb0e60d39eda418e13f7ef65a878dcce247267..318e67b5ddc0d34b7ed3acd95539a184023d3120 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
@@ -106,6 +106,14 @@ TEST_F(WebFrameSchedulerImplTest, RepeatingTimer_PageInBackground) {
1.0);
mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
+ EXPECT_EQ(1000, run_count);
+
+ // The task queue isn't throttled at all until it's been in the background for
+ // a 10 second grace period.
+ clock_->Advance(base::TimeDelta::FromSeconds(10));
+
+ run_count = 0;
+ mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
EXPECT_EQ(1, run_count);
}
@@ -164,10 +172,19 @@ TEST_F(WebFrameSchedulerImplTest, PageInBackground_ThrottlingDisabled) {
1.0);
mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
+ EXPECT_EQ(1000, run_count);
+
+ // The task queue isn't throttled at all until it's been in the background for
+ // a 10 second grace period.
+ clock_->Advance(base::TimeDelta::FromSeconds(10));
+
+ run_count = 0;
+ mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
EXPECT_EQ(1, run_count);
}
-TEST_F(WebFrameSchedulerImplTest, RepeatingTimer_FrameHidden_CrossOrigin_ThrottlingDisabled) {
+TEST_F(WebFrameSchedulerImplTest,
+ RepeatingTimer_FrameHidden_CrossOrigin_ThrottlingDisabled) {
RuntimeEnabledFeatures::setTimerThrottlingForHiddenFramesEnabled(false);
web_frame_scheduler_->setFrameVisible(false);
web_frame_scheduler_->setCrossOrigin(true);

Powered by Google App Engine
This is Rietveld 408576698