Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ash/resources/vector_icons/vector_icons.cc.template

Issue 2620653004: Optimize GetPathForVectorIcon*, save ~290 KB on disk (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/vector_icon_types.h » ('j') | ui/gfx/vector_icon_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/resources/vector_icons/vector_icons.cc.template
diff --git a/ash/resources/vector_icons/vector_icons.cc.template b/ash/resources/vector_icons/vector_icons.cc.template
index e6f5f90101dbb63d73e8e912cae7b0bf7f998144..e48137d99f3a7818086385c94449c25d966f0f04 100644
--- a/ash/resources/vector_icons/vector_icons.cc.template
+++ b/ash/resources/vector_icons/vector_icons.cc.template
@@ -11,7 +11,7 @@
#include "ui/gfx/vector_icon_types.h"
#define PATH_ELEMENT_TEMPLATE(path_name, ...) \
-static gfx::PathElement path_name[] = {__VA_ARGS__};
+static constexpr gfx::PathElement path_name[] = {__VA_ARGS__};
Evan Stade 2017/01/10 17:30:26 is this part actually necessary? I ask because I d
brucedawson 2017/01/10 18:31:54 I meant to ask about that because changes to this
Evan Stade 2017/01/11 00:26:22 the file is used, but I suspect you're not buildin
brucedawson 2017/01/11 01:05:55 Ah. Got it. For VC++ putting constexpr on the arr
#define VECTOR_ICON_TEMPLATE(icon_name, path_name, path_name_1x) \
const gfx::VectorIcon icon_name = { path_name , path_name_1x };
« no previous file with comments | « no previous file | ui/gfx/vector_icon_types.h » ('j') | ui/gfx/vector_icon_types.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698