Implement display:flow-root

third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
  * All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
@@ skipping 65 matching lines @@
     case EDisplay::Inline:
     case EDisplay::InlineBlock:
     case EDisplay::TableRowGroup:
     case EDisplay::TableHeaderGroup:
     case EDisplay::TableFooterGroup:
     case EDisplay::TableRow:
     case EDisplay::TableColumnGroup:
     case EDisplay::TableColumn:
     case EDisplay::TableCell:
     case EDisplay::TableCaption:
+    case EDisplay::FlowRoot:

[mstensho (USE GERRIT), 2017/01/09 20:37:58]

Shouldn't you just return EDisplay::FlowRoot in this case? I.e. move it further
up to the cases that just return display?

I think the computed value of "display" should be "flow-root" here (not
"block"), for instance:

<div style="display:flow-root; float:left;">

       return EDisplay::Block;
     case EDisplay::None:
     case EDisplay::Contents:
       ASSERT_NOT_REACHED();
       return display;
   }
   ASSERT_NOT_REACHED();
   return EDisplay::Block;
 }
 
@@ skipping 380 matching lines @@
       style.setDisplay(EDisplay::Block);
 
     // Columns don't apply to svg text elements.
     if (isSVGTextElement(*element))
       style.clearMultiCol();
   }
   adjustStyleForAlignment(style, parentStyle);
 }
 
 }  // namespace blink