Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2620593002: dart2js-kernel: handle 'dynamic' as an expression (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 1ab19ec36e4760693a82839af6baf454e44bf46e..b0712ce25a864b9ead5efaa7fa144128cfd6fd53 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -1233,7 +1233,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
@override
void visitTypeLiteral(ir.TypeLiteral typeLiteral) {
ir.DartType type = typeLiteral.type;
- if (type is ir.InterfaceType) {
+ if (type is ir.InterfaceType || type is ir.DynamicType) {
ConstantValue constant = astAdapter.getConstantForType(type);
stack.add(graph.addConstant(constant, closedWorld));
return;
@@ -1251,7 +1251,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
astAdapter.createRuntimeTypeReturnType);
return;
}
- // TODO(27394): 'dynamic' and function types observed. Where are they from?
+ // TODO(27394): Function types observed. Where are they from?
defaultExpression(typeLiteral);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698