Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/objects-inl.h

Issue 262053011: Confusion on changing data property callback attributes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6394 matching lines...) Expand 10 before | Expand all | Expand 10 after
6405 } 6405 }
6406 6406
6407 6407
6408 bool AccessorInfo::IsCompatibleReceiver(Object* receiver) { 6408 bool AccessorInfo::IsCompatibleReceiver(Object* receiver) {
6409 Object* function_template = expected_receiver_type(); 6409 Object* function_template = expected_receiver_type();
6410 if (!function_template->IsFunctionTemplateInfo()) return true; 6410 if (!function_template->IsFunctionTemplateInfo()) return true;
6411 return FunctionTemplateInfo::cast(function_template)->IsTemplateFor(receiver); 6411 return FunctionTemplateInfo::cast(function_template)->IsTemplateFor(receiver);
6412 } 6412 }
6413 6413
6414 6414
6415 void ExecutableAccessorInfo::clear_setter() {
6416 set_setter(GetIsolate()->heap()->undefined_value(), SKIP_WRITE_BARRIER);
6417 }
6418
6419
6415 void AccessorPair::set_access_flags(v8::AccessControl access_control) { 6420 void AccessorPair::set_access_flags(v8::AccessControl access_control) {
6416 int current = access_flags()->value(); 6421 int current = access_flags()->value();
6417 current = BooleanBit::set(current, 6422 current = BooleanBit::set(current,
6418 kProhibitsOverwritingBit, 6423 kProhibitsOverwritingBit,
6419 access_control & PROHIBITS_OVERWRITING); 6424 access_control & PROHIBITS_OVERWRITING);
6420 current = BooleanBit::set(current, 6425 current = BooleanBit::set(current,
6421 kAllCanReadBit, 6426 kAllCanReadBit,
6422 access_control & ALL_CAN_READ); 6427 access_control & ALL_CAN_READ);
6423 current = BooleanBit::set(current, 6428 current = BooleanBit::set(current,
6424 kAllCanWriteBit, 6429 kAllCanWriteBit,
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
6856 #undef READ_SHORT_FIELD 6861 #undef READ_SHORT_FIELD
6857 #undef WRITE_SHORT_FIELD 6862 #undef WRITE_SHORT_FIELD
6858 #undef READ_BYTE_FIELD 6863 #undef READ_BYTE_FIELD
6859 #undef WRITE_BYTE_FIELD 6864 #undef WRITE_BYTE_FIELD
6860 #undef NOBARRIER_READ_BYTE_FIELD 6865 #undef NOBARRIER_READ_BYTE_FIELD
6861 #undef NOBARRIER_WRITE_BYTE_FIELD 6866 #undef NOBARRIER_WRITE_BYTE_FIELD
6862 6867
6863 } } // namespace v8::internal 6868 } } // namespace v8::internal
6864 6869
6865 #endif // V8_OBJECTS_INL_H_ 6870 #endif // V8_OBJECTS_INL_H_
OLDNEW
« src/objects.cc ('K') | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698