Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/objects-inl.h

Issue 262053011: Confusion on changing data property callback attributes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6402 matching lines...) Expand 10 before | Expand all | Expand 10 after
6413 } 6413 }
6414 6414
6415 6415
6416 bool AccessorInfo::IsCompatibleReceiver(Object* receiver) { 6416 bool AccessorInfo::IsCompatibleReceiver(Object* receiver) {
6417 Object* function_template = expected_receiver_type(); 6417 Object* function_template = expected_receiver_type();
6418 if (!function_template->IsFunctionTemplateInfo()) return true; 6418 if (!function_template->IsFunctionTemplateInfo()) return true;
6419 return FunctionTemplateInfo::cast(function_template)->IsTemplateFor(receiver); 6419 return FunctionTemplateInfo::cast(function_template)->IsTemplateFor(receiver);
6420 } 6420 }
6421 6421
6422 6422
6423 void ExecutableAccessorInfo::clear_setter() {
6424 set_setter(GetIsolate()->heap()->undefined_value(), SKIP_WRITE_BARRIER);
6425 }
6426
6427
6423 void AccessorPair::set_access_flags(v8::AccessControl access_control) { 6428 void AccessorPair::set_access_flags(v8::AccessControl access_control) {
6424 int current = access_flags()->value(); 6429 int current = access_flags()->value();
6425 current = BooleanBit::set(current, 6430 current = BooleanBit::set(current,
6426 kProhibitsOverwritingBit, 6431 kProhibitsOverwritingBit,
6427 access_control & PROHIBITS_OVERWRITING); 6432 access_control & PROHIBITS_OVERWRITING);
6428 current = BooleanBit::set(current, 6433 current = BooleanBit::set(current,
6429 kAllCanReadBit, 6434 kAllCanReadBit,
6430 access_control & ALL_CAN_READ); 6435 access_control & ALL_CAN_READ);
6431 current = BooleanBit::set(current, 6436 current = BooleanBit::set(current,
6432 kAllCanWriteBit, 6437 kAllCanWriteBit,
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
6864 #undef READ_SHORT_FIELD 6869 #undef READ_SHORT_FIELD
6865 #undef WRITE_SHORT_FIELD 6870 #undef WRITE_SHORT_FIELD
6866 #undef READ_BYTE_FIELD 6871 #undef READ_BYTE_FIELD
6867 #undef WRITE_BYTE_FIELD 6872 #undef WRITE_BYTE_FIELD
6868 #undef NOBARRIER_READ_BYTE_FIELD 6873 #undef NOBARRIER_READ_BYTE_FIELD
6869 #undef NOBARRIER_WRITE_BYTE_FIELD 6874 #undef NOBARRIER_WRITE_BYTE_FIELD
6870 6875
6871 } } // namespace v8::internal 6876 } } // namespace v8::internal
6872 6877
6873 #endif // V8_OBJECTS_INL_H_ 6878 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698