chrome.bluetoothLowEnergy: Implement getCharacteristic.

chrome.bluetoothLowEnergy: Implement getCharacteristic.

This CL implements the getCharacteristic method of the bluetoothLowEnergy API.
In addition, the instance ID mapping has been simplified by removing
BluetoothLowEnergyEventRouter::GattObjectData and keeping string to string
mappings, e.g. service ID -> device address, characteristic ID -> service ID,
etc. Also added is a browser test for characteristic properties.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268301

[rpaquay, 2014-05-05 16:07:47]

lgtm

https://codereview.chromium.org/262053003/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
(right):

https://codereview.chromium.org/262053003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:232:
SetResult(CharacteristicToValue(&characteristic).release());
Wasn't this bug was recently fixed? (crbug/ 368368)

[keybuk, 2014-05-05 16:36:01]

lgtm

[armansito, 2014-05-05 17:39:32]

https://codereview.chromium.org/262053003/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
(right):

https://codereview.chromium.org/262053003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:232:
SetResult(CharacteristicToValue(&characteristic).release());
On 2014/05/05 16:07:48, rpaquay wrote:
> Wasn't this bug was recently fixed? (crbug/ 368368)

No, it's still a problem. There is a CL that does fix it but it hasn't been
merged yet (https://codereview.chromium.org/260893013/).

[armansito, 2014-05-05 17:39:37]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-05-05 17:41:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/armansito@chromium.org/262053003/1

[commit-bot: I haz the power, 2014-05-05 23:05:14]

Change committed as 268301