Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: extensions/common/api/networking_private.idl

Issue 2620463003: Add getGlobalPolicy to networkingPrivate API. (Closed)
Patch Set: Add dcheck Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/networking_private.idl
diff --git a/extensions/common/api/networking_private.idl b/extensions/common/api/networking_private.idl
index b1855c407e404c2b9063697a53a09fdac0e303e2..6bbe08639842e736c226de091942a12b57291142 100644
--- a/extensions/common/api/networking_private.idl
+++ b/extensions/common/api/networking_private.idl
@@ -806,6 +806,15 @@ namespace networkingPrivate {
long? limit;
};
+ dictionary GlobalPolicy {
+ // If true, only policy networks may auto connect. Defaults to false.
Devlin 2017/01/10 15:25:22 "policy networks" sounds strange. Is this somethi
stevenjb 2017/01/10 17:49:39 It is "networks specified by enterprise policy",
Devlin 2017/01/10 18:43:06 But we don't use it in documentation, which this i
stevenjb 2017/01/10 18:58:29 We also don't refer to "enterprise policy" here. N
+ boolean? AllowOnlyPolicyNetworksToAutoconnect;
Devlin 2017/01/10 15:25:22 These should be javaScriptCased. Admittedly, this
stevenjb 2017/01/10 17:49:39 See comment at top of file.
Devlin 2017/01/10 18:43:06 Didn't realize these were from ONC :/
stevenjb 2017/01/10 18:58:29 Acknowledged.
+
+ // If true, only policy networks may be connected to and no new networks may
Devlin 2017/01/10 15:25:22 ditto re policy networks "may be connected to" is
stevenjb 2017/01/10 17:49:39 It's a permission so "may" is *technically* correc
Devlin 2017/01/10 18:43:06 My nit was around the phrasing. "Only policy netw
stevenjb 2017/01/10 18:58:29 Acknowledged.
+ // be added or configured. Defaults to false.
+ boolean? AllowOnlyPolicyNetworksToConnect;
Devlin 2017/01/10 15:25:22 for this and above, we call them "AllowOnlyPolicyN
stevenjb 2017/01/10 17:49:39 The names are already defined by ONC / policy.
+ };
+
callback VoidCallback = void();
callback BooleanCallback = void(boolean result);
callback StringCallback = void(DOMString result);
@@ -818,6 +827,7 @@ namespace networkingPrivate {
callback GetDeviceStatesCallback = void(DeviceStateProperties[] result);
callback GetEnabledNetworkTypesCallback = void(NetworkType[] result);
callback CaptivePortalStatusCallback = void(CaptivePortalStatus result);
+ callback GetGlobalPolicyCallback = void(GlobalPolicy result);
// These functions all report failures via chrome.runtime.lastError.
interface Functions {
@@ -1034,6 +1044,10 @@ namespace networkingPrivate {
static void setCellularSimState(DOMString networkGuid,
CellularSimState simState,
optional VoidCallback callback);
+
+ // Gets the global policy properties. These properties are not expected to
+ // change during a session.
+ static void getGlobalPolicy(GetGlobalPolicyCallback callback);
};
interface Events {

Powered by Google App Engine
This is Rietveld 408576698