Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 2620463003: Add getGlobalPolicy to networkingPrivate API. (Closed)
Patch Set: Add dcheck Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
index 02d6d1abc93783764fdd3aaecb5aa73ac1396b11..d8d0b782e4310f60915b26c450a78fb9cd33056a 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
@@ -183,6 +183,10 @@ class TestDelegate : public NetworkingPrivateDelegate {
return result;
}
+ std::unique_ptr<base::DictionaryValue> GetGlobalPolicy() override {
+ return base::MakeUnique<base::DictionaryValue>();
+ }
+
bool EnableNetworkType(const std::string& type) override {
enabled_[type] = true;
return !fail_;
@@ -462,6 +466,10 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, SetCellularSimState) {
EXPECT_TRUE(RunNetworkingSubtest("setCellularSimState")) << message_;
}
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, GetGlobalPolicy) {
+ EXPECT_TRUE(RunNetworkingSubtest("getGlobalPolicy")) << message_;
+}
+
// Test failure case
class NetworkingPrivateApiTestFail : public NetworkingPrivateApiTest {
@@ -516,6 +524,7 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, GetDeviceStates) {
// * disableNetworkType
// * enableNetworkType
// * requestNetworkScan
+// * getGlobalPolicy
IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, StartConnect) {
EXPECT_FALSE(RunNetworkingSubtest("startConnect")) << message_;

Powered by Google App Engine
This is Rietveld 408576698