extensions/browser/api/networking_private/networking_private_service_client.cc - Issue 2620463003: Add getGlobalPolicy to networkingPrivate API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_service_client.cc

Issue 2620463003: Add getGlobalPolicy to networkingPrivate API. (Closed)

Patch Set: Feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_private/networking_private_service_client.h ('k') | extensions/browser/extension_function_histogram_value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_service_client.cc

diff --git a/extensions/browser/api/networking_private/networking_private_service_client.cc b/extensions/browser/api/networking_private/networking_private_service_client.cc

index 5873218280aaa77bd4a411b4c79abfca43287bd2..7bbb6852e1951d210f086921ec2cda5e61072db7 100644

--- a/extensions/browser/api/networking_private/networking_private_service_client.cc

+++ b/extensions/browser/api/networking_private/networking_private_service_client.cc

@@ -353,6 +353,11 @@ NetworkingPrivateServiceClient::GetDeviceStateList() {

return device_state_list;

}

+std::unique_ptr<base::DictionaryValue>

+NetworkingPrivateServiceClient::GetGlobalPolicy() {

+ callback.Run(base::MakeUnique<base::DictionaryValue>());

tbarzic 2017/01/09 20:24:30 this should return unique_ptr, too :)

stevenjb 2017/01/09 20:43:34 Done.

bool NetworkingPrivateServiceClient::EnableNetworkType(

const std::string& type) {

return false;