Add getGlobalPolicy to networkingPrivate API.

extensions/browser/api/networking_private/networking_private_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_DELEGATE_H_
 #define EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_DELEGATE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 146 matching lines @@
                                  const FailureCallback& failure_callback) = 0;
   virtual void GetCaptivePortalStatus(
       const std::string& guid,
       const StringCallback& success_callback,
       const FailureCallback& failure_callback) = 0;
   virtual void UnlockCellularSim(const std::string& guid,
                                  const std::string& pin,
                                  const std::string& puk,
                                  const VoidCallback& success_callback,
                                  const FailureCallback& failure_callback) = 0;
-
   virtual void SetCellularSimState(const std::string& guid,
                                    bool require_pin,
                                    const std::string& current_pin,
                                    const std::string& new_pin,
                                    const VoidCallback& success_callback,
                                    const FailureCallback& failure_callback) = 0;
 
   // Synchronous methods
 
   // Returns a list of ONC type strings.
   virtual std::unique_ptr<base::ListValue> GetEnabledNetworkTypes() = 0;
 
   // Returns a list of DeviceStateProperties.
   virtual std::unique_ptr<DeviceStateList> GetDeviceStateList() = 0;
 
+  // Returns a dictionary of global policy values (may be empty). Note: the
+  // dictionary is expected to be a superset of the networkingPrivate
+  // GlobalPolicy dictionary. Any properties not in GlobalPolicy will be
+  // ignored.
+  virtual std::unique_ptr<base::DictionaryValue> GetGlobalPolicy() = 0;

[Devlin, 2017/01/10 15:25:22]

It looks like this is only used in the new API function, which only needs it to
get a const&.  Can we return a const DictionaryValue* to avoid the copy?

[stevenjb, 2017/01/10 17:49:39]

I guess my main objections to passing const DictionaryValue* is that it would be
inconsistent with the other delegate methods. Also, if we later merge properties
from other sources in the future, the delegate code becomes slightly awkward.

[Devlin, 2017/01/10 18:43:06]

Most other methods actually *do* create/modify the result, so it makes sense to
return a unique_ptr.  Here, we don't.  And if we later merge properties, then we
can adjust the signature again. :)

[stevenjb, 2017/01/10 18:58:29]

How strongly do you feel about this?

+
   // Returns true if the ONC network type |type| is enabled.
   virtual bool EnableNetworkType(const std::string& type) = 0;
 
   // Returns true if the ONC network type |type| is disabled.
   virtual bool DisableNetworkType(const std::string& type) = 0;
 
   // Returns true if a scan was requested. It may take many seconds for a scan
   // to complete. The scan may or may not trigger API events when complete.
   virtual bool RequestScan() = 0;
 
@@ skipping 23 matching lines @@
 
   // Interface for UI methods. May be null.
   std::unique_ptr<UIDelegate> ui_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateDelegate);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_DELEGATE_H_