Add getGlobalPolicy to networkingPrivate API.

extensions/common/api/networking_private.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The <code>chrome.networkingPrivate</code> API is used for configuring
 // network connections (Cellular, Ethernet, VPN, WiFi or WiMAX). This private
 // API is only valid if called from a browser or app associated with the
 // primary user. See the Open Network Configuration (ONC) documentation for
 // descriptions of properties:
 // <a href="https://code.google.com/p/chromium/codesearch#chromium/src/components/onc/docs/onc_spec.html">
@@ skipping 788 matching lines @@
     boolean? visible;
 
     // If true, only include configured (saved) networks. Defaults to 'false'.
     boolean? configured;
 
     // Maximum number of networks to return. Defaults to 1000 if unspecified.
     // Use 0 for no limit.
     long? limit;
   };
 
+  dictionary GlobalPolicy {
+    // If true, only allow policy networks to autoconnect. Defaults to false.

[tbarzic, 2017/01/06 22:43:18]

Since this describes state of the system, rather than a function arg, "only
allow" seems a bit misleading.
How about:
If true, only policy configured networks can auto-connect.

[stevenjb, 2017/01/09 19:30:37]

Done.

+    boolean? AllowOnlyPolicyNetworksToAutoconnect;
+
+    // If true, only allow policy networks to connect and no new networks can be
+    // added. Defaults to false.

[tbarzic, 2017/01/06 22:43:18]

I think "configured" would be clearer than "added".

[stevenjb, 2017/01/09 19:30:37]

Done.

+    boolean? AllowOnlyPolicyNetworksToConnect;
+  };
+
   callback VoidCallback = void();
   callback BooleanCallback = void(boolean result);
   callback StringCallback = void(DOMString result);
   // TODO(stevenjb): Use NetworkProperties for |result| once defined.
   callback GetPropertiesCallback = void(NetworkProperties result);
   // TODO(stevenjb): Use ManagedNetworkProperties for |result| once defined.
   callback GetManagedPropertiesCallback = void(ManagedProperties result);
   callback GetStatePropertiesCallback = void(NetworkStateProperties result);
   callback GetNetworksCallback = void(NetworkStateProperties[] result);
   callback GetDeviceStatesCallback = void(DeviceStateProperties[] result);
   callback GetEnabledNetworkTypesCallback = void(NetworkType[] result);
   callback CaptivePortalStatusCallback = void(CaptivePortalStatus result);
+  callback GetGlobalPolicyCallback = void(GlobalPolicy result);
 
   // These functions all report failures via chrome.runtime.lastError.
   interface Functions {
     // Gets all the properties of the network with id networkGuid. Includes all
     // properties of the network (read-only and read/write values).
     // |networkGuid|: The GUID of the network to get properties for.
     // |callback|: Called with the network properties when received.
     static void getProperties(DOMString networkGuid,
                               GetPropertiesCallback callback);
 
@@ skipping 196 matching lines @@
     // automatically by the device. NOTE: If the SIM is locked, it must first be
     // unlocked with unlockCellularSim() before this can be called (otherwise it
     // will fail and chrome.runtime.lastError will be set to Error.SimLocked).
     // |networkGuid|: The GUID of the cellular network to set the SIM state of.
     //     If empty, the default cellular device will be used.
     // |simState|: The SIM state to set.
     // |callback|: Called when the operation has completed.
     static void setCellularSimState(DOMString networkGuid,
                                     CellularSimState simState,
                                     optional VoidCallback callback);
+
+    // Get the global policy properties. These properties are not expected to

[tbarzic, 2017/01/06 22:43:18]

suggestion:
s/Get/Gets/
s/are not expected to change during a session/are expected to be constant within
a session/

[stevenjb, 2017/01/09 19:30:37]

Fixed Gets. 'Expected to be constant' sounds more like a code comment than an
API comment to me. *shrug*

+    // change during a session.
+    static void getGlobalPolicy(GetGlobalPolicyCallback callback);
   };
 
   interface Events {
     // Fired when the properties change on any of the networks.  Sends a list of
     // GUIDs for networks whose properties have changed.
     static void onNetworksChanged(DOMString[] changes);
 
     // Fired when the list of networks has changed.  Sends a complete list of
     // GUIDs for all the current networks.
     static void onNetworkListChanged(DOMString[] changes);
 
     // Fired when the list of devices has changed or any device state properties
     // have changed.
     static void onDeviceStateListChanged();
 
     // Fired when a portal detection for a network completes. Sends the guid of
     // the network and the corresponding captive portal status.
     static void onPortalDetectionCompleted(DOMString networkGuid,
                                            CaptivePortalStatus status);
   };
 };