Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab (Closed)
Patch Set: fix crash Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index 3b634786db3c869600cc10841358612c331612f6..5669449ed703cfe52feab5132a6010e7da6c29b1 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -1456,7 +1456,12 @@ void ResourceDispatcherHostImpl::ContinuePendingBeginRequest(
ChildProcessSecurityPolicyImpl* policy =
ChildProcessSecurityPolicyImpl::GetInstance();
bool report_raw_headers = request_data.report_raw_headers;
- if (report_raw_headers && !policy->CanReadRawCookies(child_id)) {
+ if (report_raw_headers && !policy->CanReadRawCookies(child_id) &&
+ !requester_info->IsNavigationPreload()) {
+ // For navigation preload, the child_id is -1 so CanReadRawCookies would
+ // return false. But |report_raw_headers| of the navigation preload request
+ // was copied from the original request, so this check has already been
+ // carried out.
// TODO: crbug.com/523063 can we call bad_message::ReceivedBadMessage here?
VLOG(1) << "Denied unauthorized request for raw headers";
report_raw_headers = false;
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698