third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js - Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab (Closed)

Patch Set: reuse existing instrumentation for network Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.cc ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-scope.php » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

index 8d51142723aca485a91727b1cda5e1d832defdf9..786c1056a46dd3139d9bf466726bded40013743d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

@@ -997,7 +997,7 @@ InspectorTest.preloadModule = function(moduleName)

InspectorTest.isDedicatedWorker = function(target)

{

- return target && !target.hasBrowserCapability() && target.hasJSCapability() && !target.hasNetworkCapability() && !target.hasTargetCapability();

+ return target && !target.hasBrowserCapability() && target.hasJSCapability() && target.hasNetworkCapability() && !target.hasTargetCapability();

pfeldman 2017/01/20 20:41:46 drop the network capability check altogether - it

horo 2017/01/23 08:05:32 Done.

}

InspectorTest.isServiceWorker = function(target)