Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab (Closed)
Patch Set: incorporated falken's comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index 0189baf843216e5c561f40f207c0cc740a7debcc..0a2a32f180cbc128d54f2437f50e7e4d388a93ed 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -37,6 +37,7 @@
#include "core/dom/ExecutionContextTask.h"
#include "core/dom/MessagePort.h"
#include "core/inspector/ConsoleMessage.h"
+#include "core/inspector/InspectorInstrumentation.h"
#include "core/origin_trials/OriginTrials.h"
#include "core/workers/ParentFrameTaskRunners.h"
#include "core/workers/WorkerGlobalScope.h"
@@ -197,10 +198,21 @@ void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(
waitUntilObserver->didDispatchEvent(false /* errorOccurred */);
}
+void ServiceWorkerGlobalScopeProxy::onNavigationPreloadSent(
+ int fetchEventID,
+ const WebURL& url,
+ double sentTimestamp,
+ double sentWallTime) {
+ InspectorInstrumentation::didSendNavigationPreload(
+ workerGlobalScope(), fetchEventID, url, sentTimestamp, sentWallTime);
+}
+
void ServiceWorkerGlobalScopeProxy::onNavigationPreloadResponse(
int fetchEventID,
std::unique_ptr<WebURLResponse> response,
std::unique_ptr<WebDataConsumerHandle> dataConsumeHandle) {
+ InspectorInstrumentation::didReceiveNavigationPreloadResponse(
+ workerGlobalScope(), fetchEventID, response->toResourceResponse());
FetchEvent* fetchEvent = m_pendingPreloadFetchEvents.take(fetchEventID);
DCHECK(fetchEvent);
fetchEvent->onNavigationPreloadResponse(
@@ -211,6 +223,8 @@ void ServiceWorkerGlobalScopeProxy::onNavigationPreloadResponse(
void ServiceWorkerGlobalScopeProxy::onNavigationPreloadError(
int fetchEventID,
std::unique_ptr<WebServiceWorkerError> error) {
+ InspectorInstrumentation::didReceiveNavigationPreloadError(
+ workerGlobalScope(), fetchEventID, error->message);
FetchEvent* fetchEvent = m_pendingPreloadFetchEvents.take(fetchEventID);
// This method may be called after onNavigationPreloadResponse() was called.
if (!fetchEvent)
@@ -220,6 +234,12 @@ void ServiceWorkerGlobalScopeProxy::onNavigationPreloadError(
std::move(error));
}
+void ServiceWorkerGlobalScopeProxy::onNavigationPreloadCompleted(
+ int fetchEventID) {
+ InspectorInstrumentation::didCompleteNavigationPreload(workerGlobalScope(),
+ fetchEventID);
+}
+
void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent(
int fetchEventID,
const WebServiceWorkerRequest& webRequest) {

Powered by Google App Engine
This is Rietveld 408576698