Show service worker navigation preload requests in DevTools Network tab

content/renderer/service_worker/service_worker_context_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/service_worker/service_worker_context_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 248 matching lines @@
     : public mojom::URLLoaderClient {
  public:
   NavigationPreloadRequest(int fetch_event_id,
                            const GURL& url,
                            mojom::FetchEventPreloadHandlePtr preload_handle)
       : fetch_event_id_(fetch_event_id),
         url_(url),
         url_loader_(std::move(preload_handle->url_loader)),
         binding_(this, std::move(preload_handle->url_loader_client_request)) {}
 
-  ~NavigationPreloadRequest() override {
-  }
+  ~NavigationPreloadRequest() override {}
 
   void OnReceiveResponse(
       const ResourceResponseHead& response_head,
       mojom::DownloadedTempFilePtr downloaded_file) override {
     DCHECK(!response_);
     DCHECK(!downloaded_file);
     response_ = base::MakeUnique<blink::WebURLResponse>();
     // TODO(horo): Set report_security_info to true when DevTools is attached.
     const bool report_security_info = false;
     WebURLLoaderImpl::PopulateURLResponse(url_, response_head, response_.get(),
                                           report_security_info);
     MaybeReportResponseToClient();
   }
 
   void OnReceiveRedirect(const net::RedirectInfo& redirect_info,
                          const ResourceResponseHead& response_head) override {
     // This will delete itself.
     ReportErrorToClient(
-        "Service Worker navigation preload doesn't suport redirect.");
+        "Service Worker navigation preload doesn't support redirects.");
   }
 
   void OnDataDownloaded(int64_t data_length,
                         int64_t encoded_data_length) override {
     NOTREACHED();
   }
 
   void OnTransferSizeUpdated(int32_t transfer_size_diff) override {
-    NOTREACHED();
+    // TODO(horo): Send this transfer size update notification to DevTools.
   }
 
   void OnStartLoadingResponseBody(
       mojo::ScopedDataPipeConsumerHandle body) override {
     DCHECK(!body_.is_valid());
     body_ = std::move(body);
     MaybeReportResponseToClient();
   }
 
   void OnComplete(const ResourceRequestCompletionStatus& status) override {
@@ skipping 646 matching lines @@
   TRACE_EVENT0("ServiceWorker",
                "ServiceWorkerContextClient::OnInstallEvent");
   proxy_->dispatchInstallEvent(request_id);
 }
 
 void ServiceWorkerContextClient::DispatchFetchEvent(
     int fetch_event_id,
     const ServiceWorkerFetchRequest& request,
     mojom::FetchEventPreloadHandlePtr preload_handle,
     const DispatchFetchEventCallback& callback) {
-  std::unique_ptr<NavigationPreloadRequest> preload_request =
-      preload_handle
-          ? base::MakeUnique<NavigationPreloadRequest>(
-                fetch_event_id, request.url, std::move(preload_handle))
-          : nullptr;
+  std::unique_ptr<NavigationPreloadRequest> preload_request;
+  if (preload_handle) {
+    proxy_->onNavigationPreloadSent(
+        fetch_event_id, request.url,
+        preload_handle->sent_timestamp.ToInternalValue() /
+            static_cast<double>(base::Time::kMicrosecondsPerSecond),
+        preload_handle->sent_wall_time.ToDoubleT());

[falken, 2017/01/18 14:50:07]

nit: I'd pass these as standard base/Time.h objects and just convert when we
finally pass the value to DevTools, which needs the double. Or else I'd comment
in |onNavigationPreloadSent| header what units the |double| is in.

[horo, 2017/01/19 09:57:09]

Done.

I added public/web/modules/serviceworker/DEPS and changed Source/web/DEPS and
changed the code to use base::Time until
ServiceWorkerGlobalScopeProxy::onNavigationPreloadSent().

But according to PRESUBMIT.py, we can't use base::Time in Blink core code.
https://chromium.googlesource.com/chromium/src/+/7055702/third_party/WebKit/P...

+    preload_request = base::MakeUnique<NavigationPreloadRequest>(
+        fetch_event_id, request.url, std::move(preload_handle));
+  }
   const bool navigation_preload_sent = !!preload_request;
   blink::WebServiceWorkerRequest webRequest;
   TRACE_EVENT0("ServiceWorker",
                "ServiceWorkerContextClient::DispatchFetchEvent");
   context_->fetch_event_callbacks.AddWithID(
       base::MakeUnique<FetchCallback>(callback), fetch_event_id);
   if (preload_request) {
     context_->preload_requests.AddWithID(std::move(preload_request),
                                          fetch_event_id);
   }
@@ skipping 269 matching lines @@
 
 void ServiceWorkerContextClient::OnNavigationPreloadError(
     int fetch_event_id,
     std::unique_ptr<blink::WebServiceWorkerError> error) {
   proxy_->onNavigationPreloadError(fetch_event_id, std::move(error));
   context_->preload_requests.Remove(fetch_event_id);
 }
 
 void ServiceWorkerContextClient::OnNavigationPreloadComplete(
     int fetch_event_id) {
+  proxy_->onNavigationPreloadCompleted(fetch_event_id);
   context_->preload_requests.Remove(fetch_event_id);
 }
 
 void ServiceWorkerContextClient::BindEventDispatcher(
     mojom::ServiceWorkerEventDispatcherRequest request) {
   DCHECK(context_);
   DCHECK(!context_->event_dispatcher_binding.is_bound());
   context_->event_dispatcher_binding.Bind(std::move(request));
 }
 
 base::WeakPtr<ServiceWorkerContextClient>
 ServiceWorkerContextClient::GetWeakPtr() {
   DCHECK(worker_task_runner_->RunsTasksOnCurrentThread());
   DCHECK(context_);
   return context_->weak_factory.GetWeakPtr();
 }
 
 }  // namespace content