Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Issue 2620453003: Update comments about not setting kHandlingScrollFromMainThread on subframes (Closed)
Patch Set: Update comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
index 4c27d32c64841bdf536dca0f063704c8790c73af..08005550e6fd50100c4ed0d035eff1ff51b5db1e 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
@@ -361,8 +361,11 @@ void ScrollAnimator::updateCompositorAnimations() {
}
void ScrollAnimator::addMainThreadScrollingReason() {
- // TODO(yigu): Should update the frame tree to make sure
- // the same reason is set for subframes. crbug.com/675677.
+ // Usually main thread scrolling reasons should be updated from
+ // one frame to all its descendants. khandlingScrollFromMainThread
+ // is a special case because its subframes cannot be scrolled
+ // when the reason is set. When the subframes are ready to scroll
+ // the reason has benn reset.
if (WebLayer* scrollLayer =
toWebLayer(getScrollableArea()->layerForScrolling())) {
scrollLayer->addMainThreadScrollingReasons(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698