Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2620453003: Update comments about not setting kHandlingScrollFromMainThread on subframes (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index a8d40a8c5b11c1b2e3423c6fa5bcab5be896170c..2c52617c7a6c6092ba41bdc7386526ed2d2c3e47 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -4798,6 +4798,7 @@ void FrameView::updateSubFrameScrollOnMainReason(
scrollLayer->clearMainThreadScrollingReasons(
~MainThreadScrollingReason::kHandlingScrollFromMainThread);
}
+ reasons |= scrollLayer->mainThreadScrollingReasons();
pdr. 2017/01/06 20:41:29 Will updateSubFrameScrollOnMainReason always get c
yigu 2017/01/11 22:44:45 As discussed, we will not update this reason on su
}
Frame* child = frame.tree().firstChild();
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698