tracing/tracing/metrics/compare_samples_cmdline.html - Issue 2620413003: Bisect - Average list_of_scalars in compare_samples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/compare_samples_cmdline.html

Issue 2620413003: Bisect - Average list_of_scalars in compare_samples. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/compare_samples_cmdline.html

diff --git a/tracing/tracing/metrics/compare_samples_cmdline.html b/tracing/tracing/metrics/compare_samples_cmdline.html

index b42bb266402e8b8b6bea8f8331c6c6e8267717b8..380a112646714f09e0d5df4124a1b544c3b91a6b 100644

--- a/tracing/tracing/metrics/compare_samples_cmdline.html

+++ b/tracing/tracing/metrics/compare_samples_cmdline.html

@@ -81,7 +81,8 @@ function valuesFromCharts(listOfCharts, metricName) {

if (traceName) {

if (charts.charts[chartName][traceName].type ===

'list_of_scalar_values')

- allValues.push(...charts.charts[chartName][traceName].values);

+ allValues.push(tr.b.Statistics.mean(

+ charts.charts[chartName][traceName].values));

if (charts.charts[chartName][traceName].type === 'histogram')

allValues.push(

geoMeanFromHistogram(charts.charts[chartName][traceName]));

« no previous file with comments | « no previous file | tracing/tracing/metrics/compare_samples_unittest.py » ('j') | no next file with comments »