runtime/vm/unit_test.cc - Issue 2620413002: Fix various memory leaks in unit tests detected by a new version of ASAN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unit_test.cc

Issue 2620413002: Fix various memory leaks in unit tests detected by a new version of ASAN. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/unit_test.cc

diff --git a/runtime/vm/unit_test.cc b/runtime/vm/unit_test.cc

index c036981f40df69af708bdcc060313e7348cab9a3..6511a998dd75801bf133e6dcf0fb2dd1faf79420 100644

--- a/runtime/vm/unit_test.cc

+++ b/runtime/vm/unit_test.cc

@@ -52,7 +52,7 @@ void TestCaseBase::RunAll() {

Dart_Isolate TestCase::CreateIsolate(const uint8_t* buffer, const char* name) {

- bin::IsolateData* isolate_data = new bin::IsolateData(name, NULL, NULL);

+ bin::IsolateData* isolate_data = NULL;

char* err;

Dart_Isolate isolate =

Dart_CreateIsolate(name, NULL, buffer, NULL, isolate_data, &err);

zra 2017/01/11 19:05:21 ditto

rmacnak 2017/01/11 19:11:08 Done.

« runtime/vm/benchmark_test.cc ('K') | « runtime/vm/timeline_test.cc ('k') | no next file » | no next file with comments »