Fix various memory leaks in unit tests detected by a new version of ASAN.

runtime/vm/timeline_test.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <cstring>
 
 #include "platform/assert.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
@@ skipping 73 matching lines @@
                       int64_t end) {
     ASSERT(recorder != NULL);
     ASSERT(label != NULL);
     ASSERT(end >= 0);
     TimelineEvent* event = recorder->StartEvent();
     ASSERT(event != NULL);
     event->End(label, end);
     event->Complete();
   }
 
-  static void Clear(TimelineEventEndlessRecorder* recorder) {
+  static void Clear(TimelineEventRecorder* recorder) {
     ASSERT(recorder != NULL);
     recorder->Clear();
   }
 
   static void FinishBlock(TimelineEventBlock* block) { block->Finish(); }
 };
 
 
 TEST_CASE(TimelineEventIsValid) {
   // Create a test stream.
@@ skipping 231 matching lines @@
   EXPECT_EQ(0, recorder->CountFor(TimelineEvent::kAsyncInstant));
   event->Complete();
   EXPECT_EQ(1, recorder->CountFor(TimelineEvent::kAsyncInstant));
 
   event = stream.StartEvent();
   EXPECT_EQ(0, recorder->CountFor(TimelineEvent::kAsyncEnd));
   event->AsyncEnd("asyncEndCabbage", async_id);
   EXPECT_EQ(0, recorder->CountFor(TimelineEvent::kAsyncEnd));
   event->Complete();
   EXPECT_EQ(1, recorder->CountFor(TimelineEvent::kAsyncEnd));
+
+  delete recorder;
 }
 
 
 static bool LabelMatch(TimelineEvent* event, const char* label) {
   ASSERT(event != NULL);
   return strcmp(event->label(), label) == 0;
 }
 
 
 TEST_CASE(TimelineAnalysis_ThreadBlockCount) {
@@ skipping 103 matching lines @@
     EXPECT(it.HasNext());
     EXPECT(LabelMatch(it.Next(), "C"));
     EXPECT(it.HasNext());
     EXPECT(LabelMatch(it.Next(), "D"));
     EXPECT(it.HasNext());
     EXPECT(LabelMatch(it.Next(), "E"));
     EXPECT(it.HasNext());
     EXPECT(LabelMatch(it.Next(), "F"));
     EXPECT(!it.HasNext());
   }
+
+  TimelineTestHelper::Clear(recorder);
+  delete recorder;
 }
 
 
 TEST_CASE(TimelineRingRecorderJSONOrder) {
   TimelineStream stream;
   stream.Init("testStream", true);
 
   TimelineEventRingRecorder* recorder =
       new TimelineEventRingRecorder(TimelineEventBlock::kBlockSize * 2);
 
@@ skipping 16 matching lines @@
   JSONStream js;
   TimelineEventFilter filter;
   recorder->PrintJSON(&js, &filter);
   // trace-event has a requirement that events for a thread must have
   // monotonically increasing timestamps.
   // Verify that "Alpha" comes before "Beta" even though "Beta" is in the first
   // block.
   const char* alpha = strstr(js.ToCString(), "Alpha");
   const char* beta = strstr(js.ToCString(), "Beta");
   EXPECT(alpha < beta);
+
+  TimelineTestHelper::Clear(recorder);
+  delete recorder;
 }
 
 
 TEST_CASE(TimelinePauses_Basic) {
   TimelineEventEndlessRecorder* recorder = new TimelineEventEndlessRecorder();
   ASSERT(recorder != NULL);
   Zone* zone = thread->zone();
   Isolate* isolate = thread->isolate();
   OSThread* os_thread = thread->os_thread();
   ASSERT(os_thread != NULL);
@@ skipping 152 matching lines @@
     TimelinePauses pauses(zone, isolate, recorder);
     pauses.Setup();
     pauses.CalculatePauseTimesForThread(tid);
     EXPECT(!pauses.has_error());
     EXPECT_EQ(10, pauses.InclusiveTime("a"));
     EXPECT_EQ(10, pauses.ExclusiveTime("a"));
     EXPECT_EQ(10, pauses.MaxInclusiveTime("a"));
     EXPECT_EQ(8, pauses.MaxExclusiveTime("a"));
   }
   TimelineTestHelper::Clear(recorder);
+
+  delete recorder;
 }
 
 
 TEST_CASE(TimelinePauses_BeginEnd) {
   TimelineEventEndlessRecorder* recorder = new TimelineEventEndlessRecorder();
   ASSERT(recorder != NULL);
   Zone* zone = thread->zone();
   Isolate* isolate = thread->isolate();
   OSThread* os_thread = thread->os_thread();
   ASSERT(os_thread != NULL);
@@ skipping 190 matching lines @@
   // Pop "a" without popping "b" first.
   TimelineTestHelper::FakeEnd(recorder, "a", 10);
 
   {
     TimelinePauses pauses(zone, isolate, recorder);
     pauses.Setup();
     pauses.CalculatePauseTimesForThread(tid);
     EXPECT(pauses.has_error());
   }
   TimelineTestHelper::Clear(recorder);
+
+  delete recorder;
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart