Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 2620383002: [NoStatePrefetch] Fix the PrefetchAge histogram to match histograms.xml (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_histograms.h" 5 #include "chrome/browser/prerender/prerender_histograms.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 void PrerenderHistograms::RecordPrefetchFirstContentfulPaintTime( 461 void PrerenderHistograms::RecordPrefetchFirstContentfulPaintTime(
462 Origin origin, 462 Origin origin,
463 bool is_no_store, 463 bool is_no_store,
464 bool was_hidden, 464 bool was_hidden,
465 base::TimeDelta time, 465 base::TimeDelta time,
466 base::TimeDelta prefetch_age) { 466 base::TimeDelta prefetch_age) {
467 DCHECK(thread_checker_.CalledOnValidThread()); 467 DCHECK(thread_checker_.CalledOnValidThread());
468 468
469 if (!prefetch_age.is_zero()) { 469 if (!prefetch_age.is_zero()) {
470 DCHECK_NE(origin, ORIGIN_NONE); 470 DCHECK_NE(origin, ORIGIN_NONE);
471 RecordHistogramTime( 471 RecordHistogramTime(GetHistogramName(origin, IsOriginWash(), "PrefetchAge"),
472 GetHistogramName(origin, IsOriginWash(), "Prerender.PrefetchAge"), 472 base::TimeDelta::FromMilliseconds(10),
473 base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(30), 473 base::TimeDelta::FromMinutes(30), prefetch_age, 50);
474 prefetch_age, 50);
475 } 474 }
476 475
477 std::string histogram_base_name; 476 std::string histogram_base_name;
478 if (prefetch_age.is_zero()) { 477 if (prefetch_age.is_zero()) {
479 histogram_base_name = "PrefetchTTFCP.Reference"; 478 histogram_base_name = "PrefetchTTFCP.Reference";
480 } else { 479 } else {
481 histogram_base_name = prefetch_age < base::TimeDelta::FromMinutes( 480 histogram_base_name = prefetch_age < base::TimeDelta::FromMinutes(
482 net::HttpCache::kPrefetchReuseMins) 481 net::HttpCache::kPrefetchReuseMins)
483 ? "PrefetchTTFCP.Warm" 482 ? "PrefetchTTFCP.Warm"
484 : "PrefetchTTFCP.Cold"; 483 : "PrefetchTTFCP.Cold";
485 } 484 }
486 485
487 histogram_base_name += is_no_store ? ".NoStore" : ".Cacheable"; 486 histogram_base_name += is_no_store ? ".NoStore" : ".Cacheable";
488 histogram_base_name += FirstContentfulPaintHiddenName(was_hidden); 487 histogram_base_name += FirstContentfulPaintHiddenName(was_hidden);
489 std::string histogram_name = 488 std::string histogram_name =
490 GetHistogramName(origin, IsOriginWash(), histogram_base_name); 489 GetHistogramName(origin, IsOriginWash(), histogram_base_name);
491 490
492 RecordHistogramTime(histogram_name, base::TimeDelta::FromMilliseconds(10), 491 RecordHistogramTime(histogram_name, base::TimeDelta::FromMilliseconds(10),
493 base::TimeDelta::FromMinutes(2), time, 50); 492 base::TimeDelta::FromMinutes(2), time, 50);
494 } 493 }
495 494
496 bool PrerenderHistograms::IsOriginWash() const { 495 bool PrerenderHistograms::IsOriginWash() const {
497 if (!WithinWindow()) 496 if (!WithinWindow())
498 return false; 497 return false;
499 return origin_wash_; 498 return origin_wash_;
500 } 499 }
501 500
502 } // namespace prerender 501 } // namespace prerender
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698