Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2620363002: Introduce LibraryEntity (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 chunk +8 lines, -0 lines 4 comments Download
M pkg/compiler/lib/src/elements/names.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/members_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-11 15:31:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode14 pkg/compiler/lib/src/elements/entities.dart:14: String get libraryName; I wonder if we actually ...
3 years, 11 months ago (2017-01-12 00:00:34 UTC) #3
Johnni Winther
https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode14 pkg/compiler/lib/src/elements/entities.dart:14: String get libraryName; On 2017/01/12 00:00:33, Siggi Cherem (dart-lang) ...
3 years, 11 months ago (2017-01-12 12:29:05 UTC) #4
Johnni Winther
Committed patchset #1 (id:1) manually as 9fd9b2fa847dad29bda0536a0b0ead130a2f89ba (presubmit successful).
3 years, 11 months ago (2017-01-12 12:55:02 UTC) #6
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode14 pkg/compiler/lib/src/elements/entities.dart:14: String get libraryName; On 2017/01/12 12:29:05, Johnni Winther wrote: ...
3 years, 11 months ago (2017-01-12 18:36:53 UTC) #7
Johnni Winther
3 years, 11 months ago (2017-01-13 08:27:15 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/entities.dart (right):

https://codereview.chromium.org/2620363002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:14: String get libraryName;
On 2017/01/12 18:36:53, Siggi Cherem (dart-lang) wrote:
> On 2017/01/12 12:29:05, Johnni Winther wrote:
> > On 2017/01/12 00:00:33, Siggi Cherem (dart-lang) wrote:
> > > I wonder if we actually ever want the libraryName in the entity, or just
the
> > URI
> > 
> > We don't. I'd rather use [name] but it has different semantics currently.
> 
> is the idea then to remove this field and change it to [uri]? should we mark
it
> with a comment/TODO/@deprecated?

Will do.

Powered by Google App Engine
This is Rietveld 408576698