Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/foozzie/v8_foozzie.py

Issue 2620343005: [foozzie] Improve failure state deduplication (Closed)
Patch Set: Use instrumented source output from the test cases. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/foozzie/v8_foozzie.py
diff --git a/tools/foozzie/v8_foozzie.py b/tools/foozzie/v8_foozzie.py
index 34dc86c012278fcbb093c08276c740392d08976c..707f850a310b8e1ea07f9b2da2a9bf2774d1801a 100755
--- a/tools/foozzie/v8_foozzie.py
+++ b/tools/foozzie/v8_foozzie.py
@@ -202,6 +202,8 @@ def main():
)
# Get metadata.
+ # TODO(machenbach): We probably don't need the metadata file anymore
+ # now that the metadata is printed in the test cases.
with open(options.meta_data_path) as f:
metadata = json.load(f)
@@ -242,17 +244,16 @@ def main():
if fail_bailout(second_config_output, suppress.ignore_by_output2):
return RETURN_FAIL
- difference = suppress.diff(
+ difference, source = suppress.diff(
first_config_output.stdout, second_config_output.stdout)
if difference:
# The first three entries will be parsed by clusterfuzz. Format changes
# will require changes on the clusterfuzz side.
first_config_label = '%s,%s' % (options.first_arch, options.first_config)
second_config_label = '%s,%s' % (options.second_arch, options.second_config)
- hsh = lambda x: hashlib.sha1(x).hexdigest()[:8]
print FAILURE_TEMPLATE % dict(
configs='%s:%s' % (first_config_label, second_config_label),
- sources=','.join(map(hsh, metadata['sources'])),
+ sources=hashlib.sha1(source).hexdigest()[:8],
suppression='', # We can't tie bugs to differences.
first_config_label=first_config_label,
second_config_label=second_config_label,

Powered by Google App Engine
This is Rietveld 408576698