Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2620313002: Refactor WindowProxy into Local and Remote subclasses. (Closed)
Patch Set: explicit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
9 * rights reserved. 9 * rights reserved.
10 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 10 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 document()->url().getString() + "'. " + reason + "\n"; 486 document()->url().getString() + "'. " + reason + "\n";
487 487
488 domWindow()->printErrorMessage(message); 488 domWindow()->printErrorMessage(message);
489 } 489 }
490 490
491 void LocalFrame::printNavigationWarning(const String& message) { 491 void LocalFrame::printNavigationWarning(const String& message) {
492 m_console->addMessage( 492 m_console->addMessage(
493 ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message)); 493 ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message));
494 } 494 }
495 495
496 WindowProxyManager* LocalFrame::getWindowProxyManager() const { 496 WindowProxyManagerBase* LocalFrame::getWindowProxyManager() const {
497 return m_script->getWindowProxyManager(); 497 return m_script->getWindowProxyManager();
498 } 498 }
499 499
500 bool LocalFrame::shouldClose() { 500 bool LocalFrame::shouldClose() {
501 // TODO(dcheng): This should be fixed to dispatch beforeunload events to 501 // TODO(dcheng): This should be fixed to dispatch beforeunload events to
502 // both local and remote frames. 502 // both local and remote frames.
503 return m_loader.shouldClose(); 503 return m_loader.shouldClose();
504 } 504 }
505 505
506 void LocalFrame::detachChildren() { 506 void LocalFrame::detachChildren() {
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext()) 942 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
943 m_frame->client()->frameBlameContext()->Enter(); 943 m_frame->client()->frameBlameContext()->Enter();
944 } 944 }
945 945
946 ScopedFrameBlamer::~ScopedFrameBlamer() { 946 ScopedFrameBlamer::~ScopedFrameBlamer() {
947 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext()) 947 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
948 m_frame->client()->frameBlameContext()->Leave(); 948 m_frame->client()->frameBlameContext()->Leave();
949 } 949 }
950 950
951 } // namespace blink 951 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.h ('k') | third_party/WebKit/Source/core/frame/RemoteFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698