Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2620313002: Refactor WindowProxy into Local and Remote subclasses. (Closed)
Patch Set: explicit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 class FrameHost; 47 class FrameHost;
48 class FrameOwner; 48 class FrameOwner;
49 class HTMLFrameOwnerElement; 49 class HTMLFrameOwnerElement;
50 class LayoutPart; 50 class LayoutPart;
51 class LayoutPartItem; 51 class LayoutPartItem;
52 class KURL; 52 class KURL;
53 class Page; 53 class Page;
54 class SecurityContext; 54 class SecurityContext;
55 class Settings; 55 class Settings;
56 class WindowProxy; 56 class WindowProxy;
57 class WindowProxyManager; 57 class WindowProxyManagerBase;
58 struct FrameLoadRequest; 58 struct FrameLoadRequest;
59 59
60 enum class FrameDetachType { Remove, Swap }; 60 enum class FrameDetachType { Remove, Swap };
61 61
62 // Status of user gesture. 62 // Status of user gesture.
63 enum class UserGestureStatus { Active, None }; 63 enum class UserGestureStatus { Active, None };
64 64
65 // Frame is the base class of LocalFrame and RemoteFrame and should only contain 65 // Frame is the base class of LocalFrame and RemoteFrame and should only contain
66 // functionality shared between both. In particular, any method related to 66 // functionality shared between both. In particular, any method related to
67 // input, layout, or painting probably belongs on LocalFrame. 67 // input, layout, or painting probably belongs on LocalFrame.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 136
137 Settings* settings() const; // can be null 137 Settings* settings() const; // can be null
138 138
139 // isLoading() is true when the embedder should think a load is in progress. 139 // isLoading() is true when the embedder should think a load is in progress.
140 // In the case of LocalFrames, it means that the frame has sent a 140 // In the case of LocalFrames, it means that the frame has sent a
141 // didStartLoading() callback, but not the matching didStopLoading(). Inside 141 // didStartLoading() callback, but not the matching didStopLoading(). Inside
142 // blink, you probably want Document::loadEventFinished() instead. 142 // blink, you probably want Document::loadEventFinished() instead.
143 void setIsLoading(bool isLoading) { m_isLoading = isLoading; } 143 void setIsLoading(bool isLoading) { m_isLoading = isLoading; }
144 bool isLoading() const { return m_isLoading; } 144 bool isLoading() const { return m_isLoading; }
145 145
146 virtual WindowProxyManager* getWindowProxyManager() const = 0; 146 virtual WindowProxyManagerBase* getWindowProxyManager() const = 0;
147 147
148 virtual void didChangeVisibilityState(); 148 virtual void didChangeVisibilityState();
149 149
150 bool isDetaching() const { return m_isDetaching; } 150 bool isDetaching() const { return m_isDetaching; }
151 151
152 protected: 152 protected:
153 Frame(FrameClient*, FrameHost*, FrameOwner*); 153 Frame(FrameClient*, FrameHost*, FrameOwner*);
154 154
155 mutable FrameTree m_treeNode; 155 mutable FrameTree m_treeNode;
156 156
(...skipping 22 matching lines...) Expand all
179 return m_treeNode; 179 return m_treeNode;
180 } 180 }
181 181
182 // Allow equality comparisons of Frames by reference or pointer, 182 // Allow equality comparisons of Frames by reference or pointer,
183 // interchangeably. 183 // interchangeably.
184 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame) 184 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame)
185 185
186 } // namespace blink 186 } // namespace blink
187 187
188 #endif // Frame_h 188 #endif // Frame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698