Refactor WindowProxy into Local and Remote subclasses.

third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WindowProxyManager_h
 #define WindowProxyManager_h
 
+#include "bindings/core/v8/LocalWindowProxy.h"
+#include "bindings/core/v8/RemoteWindowProxy.h"
 #include "core/CoreExport.h"
+#include "core/frame/LocalFrame.h"
+#include "core/frame/RemoteFrame.h"
 #include "platform/heap/Handle.h"
-#include "wtf/Vector.h"
 #include <utility>
 #include <v8.h>
 
 namespace blink {
 
 class DOMWrapperWorld;
-class Frame;
 class SecurityOrigin;
-class WindowProxy;
+class ScriptController;
 
-class CORE_EXPORT WindowProxyManager final
-    : public GarbageCollected<WindowProxyManager> {
+class WindowProxyManagerBase : public GarbageCollected<WindowProxyManagerBase> {
  public:
-  static WindowProxyManager* create(Frame&);
-
   DECLARE_TRACE();
 
-  Frame* frame() const { return m_frame.get(); }
   v8::Isolate* isolate() const { return m_isolate; }
+
+  void clearForClose();
+  void CORE_EXPORT clearForNavigation();
+
+  void CORE_EXPORT
+  releaseGlobals(HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>&);
+  void CORE_EXPORT
+  setGlobals(const HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>&);
+
+ protected:
+  using IsolatedWorldMap = HeapHashMap<int, Member<WindowProxy>>;
+
+  explicit WindowProxyManagerBase(Frame&);
+
+  Frame* frame() const { return m_frame; }
   WindowProxy* mainWorldProxy() const { return m_windowProxy.get(); }
-
   WindowProxy* windowProxy(DOMWrapperWorld&);
 
-  void clearForClose();
-  void clearForNavigation();
+  IsolatedWorldMap& isolatedWorlds() { return m_isolatedWorlds; }
+
+ private:
+  v8::Isolate* const m_isolate;
+  const Member<Frame> m_frame;
+  const Member<WindowProxy> m_windowProxy;
+  IsolatedWorldMap m_isolatedWorlds;
+};
+
+template <typename FrameType, typename ProxyType>
+class WindowProxyManagerImplHelper : public WindowProxyManagerBase {

[haraken, 2017/01/11 12:33:16]

Why do we need the ImplHelper? i.e., Can we reorganize the class hierarchy like
this?

class WindowProxyManager { };
class LocalWindowProxyManager : public WindowProxyManager { };
class RemoteWindowProxyManager : public WindowProxyManager { };

[dcheng, 2017/01/11 16:12:40]

I split it into two portions so that we will have just one copy of the shared
functionality: usually, the linker should be able to merge the two copies, but
there's no guarantee that it will do so. In addition, it allows us to
out-of-line non-trivial functions. This is a pattern used by things like
RefCountedBase + RefCounted, etc as well.

+ private:
+  using Base = WindowProxyManagerBase;
+
+ public:
+  FrameType* frame() const { return static_cast<FrameType*>(Base::frame()); }
+  ProxyType* mainWorldProxy() const {
+    return static_cast<ProxyType*>(Base::mainWorldProxy());
+  }
+  ProxyType* windowProxy(DOMWrapperWorld& world) {
+    return static_cast<ProxyType*>(Base::windowProxy(world));
+  }
+
+ protected:
+  explicit WindowProxyManagerImplHelper(Frame& frame)
+      : WindowProxyManagerBase(frame) {}
+};
+
+class LocalWindowProxyManager
+    : public WindowProxyManagerImplHelper<LocalFrame, LocalWindowProxy> {
+ public:
+  static LocalWindowProxyManager* create(LocalFrame& frame) {
+    return new LocalWindowProxyManager(frame);
+  }
 
   // Sets the given security origin to the main world's context.  Also updates
   // the security origin of the context for each isolated world.
   void updateSecurityOrigin(SecurityOrigin*);
 
-  void releaseGlobals(HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>&);
-  void setGlobals(const HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>&);
+ private:
+  // TODO(dcheng): Merge LocalWindowProxyManager and ScriptController?
+  friend class ScriptController;
+
+  LocalWindowProxyManager(LocalFrame& frame)

[haraken, 2017/01/11 12:33:16]

Add explicit.

[dcheng, 2017/01/11 16:12:40]

Done.

+      : WindowProxyManagerImplHelper<LocalFrame, LocalWindowProxy>(frame) {}
+};
+
+class RemoteWindowProxyManager
+    : public WindowProxyManagerImplHelper<RemoteFrame, RemoteWindowProxy> {
+ public:
+  static RemoteWindowProxyManager* create(RemoteFrame& frame) {
+    return new RemoteWindowProxyManager(frame);
+  }
 
  private:
-  typedef HeapHashMap<int, Member<WindowProxy>> IsolatedWorldMap;
-
-  explicit WindowProxyManager(Frame&);
-
-  Member<Frame> m_frame;
-  v8::Isolate* const m_isolate;
-
-  const Member<WindowProxy> m_windowProxy;
-  IsolatedWorldMap m_isolatedWorlds;
+  RemoteWindowProxyManager(RemoteFrame& frame)

[haraken, 2017/01/11 12:33:16]

Add explicit.

[dcheng, 2017/01/11 16:12:40]

Done.

+      : WindowProxyManagerImplHelper<RemoteFrame, RemoteWindowProxy>(frame) {}
 };
 
 }  // namespace blink
 
 #endif  // WindowProxyManager_h