Refactor WindowProxy into Local and Remote subclasses.

third_party/WebKit/Source/bindings/core/v8/ScriptController.h

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 34 matching lines @@
 #include <v8.h>
 
 namespace blink {
 
 class CompiledScript;
 class DOMWrapperWorld;
 class Element;
 class KURL;
 class ScriptSourceCode;
 class SecurityOrigin;
-class WindowProxy;
 class Widget;
 
 typedef WTF::Vector<v8::Extension*> V8Extensions;
 
 enum ReasonForCallingCanExecuteScripts {
   AboutToExecuteScript,
   NotAboutToExecuteScript
 };
 
 class CORE_EXPORT ScriptController final
     : public GarbageCollected<ScriptController> {
   WTF_MAKE_NONCOPYABLE(ScriptController);
 
  public:
   enum ExecuteScriptPolicy {
     ExecuteScriptWhenScriptsDisabled,
     DoNotExecuteScriptWhenScriptsDisabled
   };
 
   static ScriptController* create(LocalFrame* frame) {
     return new ScriptController(frame);
   }
 
   DECLARE_TRACE();
 
   // This returns an initialized window proxy. (If the window proxy is not
   // yet initialized, it's implicitly initialized at the first access.)
-  WindowProxy* windowProxy(DOMWrapperWorld&);
+  LocalWindowProxy* windowProxy(DOMWrapperWorld&);

[Yuki, 2017/01/11 10:09:24]

nit: I don't fully understand why you made RefPtr<DOMWrapperWorld> in
WindowProxy, but if it's better, why did you leave this a reference?

[dcheng, 2017/01/11 10:35:28]

WindowProxy takes a reference when we construct it, so to indicate that, the
constructor / create factory functions take a RefPtr.

Logically, this function is for looking up window proxies -- while it might
sometimes ref them when it needs to construct a new one, that is an internal
implementation detail. Thus, this takes a DOMWrapperWorld& instead of a
RefPtr<DOMWrapperWorld>.

 
   // Evaluate JavaScript in the main world.
   void executeScriptInMainWorld(
       const String&,
       ExecuteScriptPolicy = DoNotExecuteScriptWhenScriptsDisabled);
   void executeScriptInMainWorld(const ScriptSourceCode&,
                                 AccessControlStatus = NotSharableCrossOrigin);
   v8::Local<v8::Value> executeScriptInMainWorldAndReturnValue(
       const ScriptSourceCode&,
       ExecuteScriptPolicy = DoNotExecuteScriptWhenScriptsDisabled);
@@ skipping 47 matching lines @@
   void clearForClose();
 
   // Registers a v8 extension to be available on webpages. Will only
   // affect v8 contexts initialized after this call. Takes ownership of
   // the v8::Extension object passed.
   static void registerExtensionIfNeeded(v8::Extension*);
   static V8Extensions& registeredExtensions();
 
   v8::Isolate* isolate() const { return m_windowProxyManager->isolate(); }
 
-  WindowProxyManager* getWindowProxyManager() const {
+  LocalWindowProxyManager* getWindowProxyManager() const {
     return m_windowProxyManager.get();
   }
 
  private:
   explicit ScriptController(LocalFrame*);
 
-  LocalFrame* frame() const {
-    return toLocalFrame(m_windowProxyManager->frame());
-  }
+  LocalFrame* frame() const { return m_windowProxyManager->frame(); }
 
   v8::Local<v8::Value> evaluateScriptInMainWorld(const ScriptSourceCode&,
                                                  AccessControlStatus,
                                                  ExecuteScriptPolicy);
 
-  Member<WindowProxyManager> m_windowProxyManager;
+  Member<LocalWindowProxyManager> m_windowProxyManager;
 };
 
 }  // namespace blink
 
 #endif  // ScriptController_h