Refactor WindowProxy into Local and Remote subclasses.

third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WindowProxy_h
-#define WindowProxy_h
+#ifndef LocalWindowProxy_h
+#define LocalWindowProxy_h
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
-#include "bindings/core/v8/ScopedPersistent.h"
-#include "bindings/core/v8/ScriptState.h"
-#include "platform/heap/Handle.h"
-#include "platform/weborigin/SecurityOrigin.h"
-#include "wtf/HashMap.h"
-#include "wtf/PassRefPtr.h"
+#include "bindings/core/v8/WindowProxy.h"
+#include "core/frame/LocalFrame.h"
 #include "wtf/RefPtr.h"
 #include "wtf/text/AtomicString.h"
 #include <v8.h>
 
 namespace blink {
 
-class Frame;
 class HTMLDocument;
 class SecurityOrigin;
 
-// WindowProxy represents all the per-global object state for a Frame that
-// persist between navigations.
-class WindowProxy final : public GarbageCollectedFinalized<WindowProxy> {
+// Subclass of WindowProxy that only handles LocalFrame.
+class LocalWindowProxy final : public WindowProxy {
  public:
-  static WindowProxy* create(v8::Isolate*, Frame*, DOMWrapperWorld&);
+  static LocalWindowProxy* create(LocalFrame& frame,
+                                  v8::Isolate* isolate,
+                                  RefPtr<DOMWrapperWorld> world) {
+    return new LocalWindowProxy(frame, isolate, std::move(world));
+  }
 
-  ~WindowProxy();
-  DECLARE_TRACE();
-
-  v8::Local<v8::Context> contextIfInitialized() const {
-    return m_scriptState ? m_scriptState->context() : v8::Local<v8::Context>();
-  }
-  ScriptState* getScriptState() const { return m_scriptState.get(); }
+  ~LocalWindowProxy() override;

[Yuki, 2017/01/11 10:09:24]

nit: "= default" should work.  WindowProxy::~WindowProxy already has DCHECK.

[dcheng, 2017/01/11 10:35:28]

Removed, since that's equivalent to = default.

 
   // Update document object of the frame.
   void updateDocument();
 
   void namedItemAdded(HTMLDocument*, const AtomicString&);
   void namedItemRemoved(HTMLDocument*, const AtomicString&);
 
   // Update the security origin of a document
   // (e.g., after setting docoument.domain).
   void updateSecurityOrigin(SecurityOrigin*);
 
-  void initializeIfNeeded();
+ private:
+  LocalWindowProxy(LocalFrame&, v8::Isolate*, RefPtr<DOMWrapperWorld>);
 
-  void clearForNavigation();
-  void clearForClose();
+  void initialize() override;
+  void disposeContext(GlobalDetachmentBehavior) override;
 
-  v8::Local<v8::Object> globalIfNotDetached();
-  v8::Local<v8::Object> releaseGlobal();
-  void setGlobal(v8::Local<v8::Object>);
-
-  DOMWrapperWorld& world() { return *m_world; }
-
- private:
-  // A valid transition is from ContextUninitialized to ContextInitialized,
-  // and then ContextDetached. Other transitions are forbidden.
-  enum class Lifecycle {
-    ContextUninitialized,
-    ContextInitialized,
-    ContextDetached,
-  };
-
-  WindowProxy(Frame*, PassRefPtr<DOMWrapperWorld>, v8::Isolate*);
-  void initialize();
-
-  enum GlobalDetachmentBehavior { DoNotDetachGlobal, DetachGlobal };
-  void disposeContext(GlobalDetachmentBehavior);
+  // Creates a new v8::Context with the window wrapper object as the global
+  // object (aka the inner global).  Note that the window wrapper and its
+  // prototype chain do not get fully initialized yet, e.g. the window
+  // wrapper is not yet associated with the native DOMWindow object.
+  void createContext();
 
   void setSecurityToken(SecurityOrigin*);
 
   // The JavaScript wrapper for the document object is cached on the global
   // object for fast access. UpdateDocumentProperty sets the wrapper
   // for the current document on the global object.
   void updateDocumentProperty();
 
   // Updates Activity Logger for the current context.
   void updateActivityLogger();
 
-  // Creates a new v8::Context with the window wrapper object as the global
-  // object (aka the inner global).  Note that the window wrapper and its
-  // prototype chain do not get fully initialized yet, e.g. the window
-  // wrapper is not yet associated with the native DOMWindow object.
-  void createContext();
-
-  // Associates the window wrapper and its prototype chain with the native
-  // DOMWindow object.  Also does some more Window-specific initialization.
-  void setupWindowPrototypeChain();
-
-  Member<Frame> m_frame;
-  v8::Isolate* m_isolate;
-  RefPtr<ScriptState> m_scriptState;
-  RefPtr<DOMWrapperWorld> m_world;
-  ScopedPersistent<v8::Object> m_globalProxy;
-  Lifecycle m_lifecycle;
+  LocalFrame* frame() const { return toLocalFrame(WindowProxy::frame()); }
 };
 
 }  // namespace blink
 
-#endif  // WindowProxy_h
+#endif  // LocalWindowProxy_h