Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: remoting/client/jni/remoting_jni_onload.cc

Issue 2620303004: Remove JNI onload callback vector construction in favour of direct calls. (Closed)
Patch Set: rebase compile errors Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/base_jni_onload.h" 5 #include "base/android/base_jni_onload.h"
6 #include "base/android/base_jni_registrar.h" 6 #include "base/android/base_jni_registrar.h"
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_registrar.h" 8 #include "base/android/jni_registrar.h"
9 #include "base/android/jni_utils.h" 9 #include "base/android/jni_utils.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "net/android/net_jni_registrar.h" 12 #include "net/android/net_jni_registrar.h"
13 #include "remoting/client/jni/remoting_jni_registrar.h" 13 #include "remoting/client/jni/remoting_jni_registrar.h"
14 #include "ui/gfx/android/gfx_jni_registrar.h" 14 #include "ui/gfx/android/gfx_jni_registrar.h"
15 15
16 namespace { 16 namespace {
17 17
18 base::android::RegistrationMethod kRemotingRegisteredMethods[] = { 18 base::android::RegistrationMethod kRemotingRegisteredMethods[] = {
19 {"base", base::android::RegisterJni}, 19 {"base", base::android::RegisterJni},
20 {"gfx", gfx::android::RegisterJni}, 20 {"gfx", gfx::android::RegisterJni},
21 {"net", net::android::RegisterJni}, 21 {"net", net::android::RegisterJni},
22 {"remoting", remoting::RegisterJni}, 22 {"remoting", remoting::RegisterJni},
23 }; 23 };
24 24
25 bool RegisterJNI(JNIEnv* env) { 25 bool RegisterJNI(JNIEnv* env) {
26 return base::android::RegisterNativeMethods(env, 26 return base::android::RegisterNativeMethods(
27 kRemotingRegisteredMethods, arraysize(kRemotingRegisteredMethods)); 27 env, kRemotingRegisteredMethods, arraysize(kRemotingRegisteredMethods));
28 } 28 }
29 29
30 } // namespace 30 } // namespace
31 31
32 JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 32 JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
33 std::vector<base::android::RegisterCallback> register_callbacks; 33 base::android::InitVM(vm);
34 register_callbacks.push_back(base::Bind(&RegisterJNI)); 34 JNIEnv* env = base::android::AttachCurrentThread();
35 std::vector<base::android::InitCallback> init_callbacks; 35 if (!base::android::OnJNIOnLoadRegisterJNI(env) || !RegisterJNI(env) ||
36 if (!base::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) || 36 !base::android::OnJNIOnLoadInit()) {
37 !base::android::OnJNIOnLoadInit(init_callbacks)) {
38 return -1; 37 return -1;
39 } 38 }
40 return JNI_VERSION_1_4; 39 return JNI_VERSION_1_4;
41 } 40 }
OLDNEW
« no previous file with comments | « net/test/android/net_test_jni_onload.cc ('k') | testing/android/native_test/native_test_jni_onload.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698