Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: testing/android/native_test/native_test_jni_onload.cc

Issue 2620303004: Remove JNI onload callback vector construction in favour of direct calls. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/base_jni_onload.h" 5 #include "base/android/base_jni_onload.h"
6 #include "base/android/jni_android.h" 6 #include "base/android/jni_android.h"
7 #include "base/android/library_loader/library_loader_hooks.h"
7 #include "base/bind.h" 8 #include "base/bind.h"
8 #include "testing/android/native_test/native_test_launcher.h" 9 #include "testing/android/native_test/native_test_launcher.h"
9 10
10 namespace { 11 namespace {
11 12
12 bool RegisterJNI(JNIEnv* env) { 13 bool RegisterJNI() {
13 return testing::android::RegisterNativeTestJNI(env); 14 return testing::android::RegisterNativeTestJNI(
15 base::android::AttachCurrentThread());
14 } 16 }
15 17
16 bool Init() { 18 bool NativeInit() {
19 if (!base::android::OnJNIOnLoadInit())
20 return false;
17 testing::android::InstallHandlers(); 21 testing::android::InstallHandlers();
18 return true; 22 return true;
19 } 23 }
20 24
21 } // namespace 25 } // namespace
22 26
23 27
24 // This is called by the VM when the shared library is first loaded. 28 // This is called by the VM when the shared library is first loaded.
25 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 29 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
26 std::vector<base::android::RegisterCallback> register_callbacks; 30 if (!base::android::OnJNIOnLoadRegisterJNI(vm) || !RegisterJNI() ||
27 register_callbacks.push_back(base::Bind(&RegisterJNI)); 31 !NativeInit()) {
28
29 if (!base::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks))
30 return -1; 32 return -1;
31 33 }
32 std::vector<base::android::InitCallback> init_callbacks;
33 init_callbacks.push_back(base::Bind(&Init));
34 if (!base::android::OnJNIOnLoadInit(init_callbacks))
35 return -1;
36
37 return JNI_VERSION_1_4; 34 return JNI_VERSION_1_4;
38 } 35 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698