Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: content/shell/android/shell_library_loader.cc

Issue 2620303004: Remove JNI onload callback vector construction in favour of direct calls. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/jni_android.h" 5 #include "base/android/jni_android.h"
6 #include "base/android/library_loader/library_loader_hooks.h"
6 #include "base/bind.h" 7 #include "base/bind.h"
7 #include "content/public/app/content_jni_onload.h" 8 #include "content/public/app/content_jni_onload.h"
8 #include "content/public/app/content_main.h" 9 #include "content/public/app/content_main.h"
9 #include "content/public/browser/android/compositor.h" 10 #include "content/public/browser/android/compositor.h"
10 #include "content/shell/android/shell_jni_registrar.h" 11 #include "content/shell/android/shell_jni_registrar.h"
11 #include "content/shell/app/shell_main_delegate.h" 12 #include "content/shell/app/shell_main_delegate.h"
12 13
13 namespace { 14 namespace {
14 15
15 bool RegisterJNI(JNIEnv* env) { 16 bool RegisterJNI() {
16 return content::android::RegisterShellJni(env); 17 return content::android::RegisterShellJni(
18 base::android::AttachCurrentThread());
17 } 19 }
18 20
19 bool Init() { 21 bool NativeInit() {
22 if (!content::android::OnJNIOnLoadInit())
23 return false;
24
20 content::Compositor::Initialize(); 25 content::Compositor::Initialize();
21 content::SetContentMainDelegate(new content::ShellMainDelegate()); 26 content::SetContentMainDelegate(new content::ShellMainDelegate());
22 return true; 27 return true;
23 } 28 }
24 29
25 } // namespace 30 } // namespace
26 31
27 32
28 // This is called by the VM when the shared library is first loaded. 33 // This is called by the VM when the shared library is first loaded.
29 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 34 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
30 std::vector<base::android::RegisterCallback> register_callbacks; 35 if (!content::android::OnJNIOnLoadRegisterJNI(vm) || !RegisterJNI() ||
31 register_callbacks.push_back(base::Bind(&RegisterJNI)); 36 !NativeInit()) {
32 std::vector<base::android::InitCallback> init_callbacks;
33 init_callbacks.push_back(base::Bind(&Init));
34 if (!content::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) ||
35 !content::android::OnJNIOnLoadInit(init_callbacks)) {
36 return -1; 37 return -1;
37 } 38 }
38 return JNI_VERSION_1_4; 39 return JNI_VERSION_1_4;
39 } 40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698