Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: components/test/android/browsertests_apk/components_browser_tests_jni_onload.cc

Issue 2620303004: Remove JNI onload callback vector construction in favour of direct calls. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/base_jni_registrar.h" 5 #include "base/android/base_jni_registrar.h"
6 #include "base/android/jni_android.h" 6 #include "base/android/jni_android.h"
7 #include "base/android/library_loader/library_loader_hooks.h"
7 #include "base/bind.h" 8 #include "base/bind.h"
8 #include "content/public/app/content_jni_onload.h" 9 #include "content/public/app/content_jni_onload.h"
9 #include "content/public/app/content_main.h" 10 #include "content/public/app/content_main.h"
10 #include "content/shell/android/shell_jni_registrar.h" 11 #include "content/shell/android/shell_jni_registrar.h"
11 #include "content/shell/app/shell_main_delegate.h" 12 #include "content/shell/app/shell_main_delegate.h"
12 #include "testing/android/native_test/native_test_launcher.h" 13 #include "testing/android/native_test/native_test_launcher.h"
13 14
14 namespace { 15 namespace {
15 16
16 bool RegisterJNI(JNIEnv* env) { 17 bool RegisterJNI() {
18 JNIEnv* env = base::android::AttachCurrentThread();
17 return base::android::RegisterJni(env) && 19 return base::android::RegisterJni(env) &&
18 content::android::RegisterShellJni(env) && 20 content::android::RegisterShellJni(env) &&
19 testing::android::RegisterNativeTestJNI(env); 21 testing::android::RegisterNativeTestJNI(env);
20 } 22 }
21 23
22 bool Init() { 24 bool NativeInit() {
25 if (!content::android::OnJNIOnLoadInit())
26 return false;
23 content::SetContentMainDelegate(new content::ShellMainDelegate()); 27 content::SetContentMainDelegate(new content::ShellMainDelegate());
24 return true; 28 return true;
25 } 29 }
26 30
27 } // namespace 31 } // namespace
28 32
29 // This is called by the VM when the shared library is first loaded. 33 // This is called by the VM when the shared library is first loaded.
30 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 34 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
31 std::vector<base::android::RegisterCallback> register_callbacks; 35 if (!content::android::OnJNIOnLoadRegisterJNI(vm) || !RegisterJNI() ||
32 register_callbacks.push_back(base::Bind(&RegisterJNI)); 36 !NativeInit()) {
33 std::vector<base::android::InitCallback> init_callbacks;
34 init_callbacks.push_back(base::Bind(&Init));
35 if (!content::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) ||
36 !content::android::OnJNIOnLoadInit(init_callbacks)) {
37 return -1; 37 return -1;
38 } 38 }
39 return JNI_VERSION_1_4; 39 return JNI_VERSION_1_4;
40 } 40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698