Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chromecast/app/android/cast_jni_loader.cc

Issue 2620303004: Remove JNI onload callback vector construction in favour of direct calls. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/jni_android.h" 5 #include "base/android/jni_android.h"
6 #include "base/android/library_loader/library_loader_hooks.h"
6 #include "base/bind.h" 7 #include "base/bind.h"
7 #include "chromecast/android/cast_jni_registrar.h" 8 #include "chromecast/android/cast_jni_registrar.h"
8 #include "chromecast/android/platform_jni_loader.h" 9 #include "chromecast/android/platform_jni_loader.h"
9 #include "chromecast/app/cast_main_delegate.h" 10 #include "chromecast/app/cast_main_delegate.h"
10 #include "content/public/app/content_jni_onload.h" 11 #include "content/public/app/content_jni_onload.h"
11 #include "content/public/app/content_main.h" 12 #include "content/public/app/content_main.h"
12 #include "content/public/browser/android/compositor.h" 13 #include "content/public/browser/android/compositor.h"
13 14
14 namespace { 15 namespace {
15 16
16 bool RegisterJNI(JNIEnv* env) { 17 bool RegisterJNI() {
18 JNIEnv* env = base::android::AttachCurrentThread();
17 // To be called only from the UI thread. If loading the library is done on 19 // To be called only from the UI thread. If loading the library is done on
18 // a separate thread, this should be moved elsewhere. 20 // a separate thread, this should be moved elsewhere.
19 if (!chromecast::android::RegisterJni(env)) 21 if (!chromecast::android::RegisterJni(env))
20 return false; 22 return false;
21 // Allow platform-specific implementations to perform more JNI registration. 23 // Allow platform-specific implementations to perform more JNI registration.
22 if (!chromecast::android::PlatformRegisterJni(env)) 24 if (!chromecast::android::PlatformRegisterJni(env))
23 return false; 25 return false;
24 return true; 26 return true;
25 } 27 }
26 28
27 bool Init() { 29 bool NativeInit() {
30 if (!content::android::OnJNIOnLoadInit())
31 return false;
28 content::Compositor::Initialize(); 32 content::Compositor::Initialize();
29 content::SetContentMainDelegate(new chromecast::shell::CastMainDelegate); 33 content::SetContentMainDelegate(new chromecast::shell::CastMainDelegate);
30 return true; 34 return true;
31 } 35 }
32 36
33 } // namespace 37 } // namespace
34 38
35 // This is called by the VM when the shared library is first loaded. 39 // This is called by the VM when the shared library is first loaded.
36 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 40 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
37 std::vector<base::android::RegisterCallback> register_callbacks; 41 if (!content::android::OnJNIOnLoadRegisterJNI(vm) || !RegisterJNI() ||
38 register_callbacks.push_back(base::Bind(&RegisterJNI)); 42 !NativeInit()) {
39 std::vector<base::android::InitCallback> init_callbacks;
40 init_callbacks.push_back(base::Bind(&Init));
41 if (!content::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) ||
42 !content::android::OnJNIOnLoadInit(init_callbacks)) {
43 return -1; 43 return -1;
44 } 44 }
45 return JNI_VERSION_1_4; 45 return JNI_VERSION_1_4;
46 } 46 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698