Remove JNI onload callback vector construction in favour of direct calls.

base/android/base_jni_onload.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/base_jni_onload.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_utils.h"
 #include "base/android/library_loader/library_loader_hooks.h"
 #include "base/bind.h"
 
 namespace base {
 namespace android {
 
-namespace {
+bool OnJNIOnLoadRegisterJNI(JavaVM* vm) {
+  base::android::InitVM(vm);

[Torne, 2017/01/12 13:33:52]

Rather than passing JavaVM down through the RegisterJNI sequence we should just
call InitVM and AttachCurrentThread in each JNI_OnLoad and then pass the JNIEnv
down through RegisterJNI instead.

We always need to do InitVM even if we don't need JNI registration, I think it
makes most sense to just do it at the top level even though that means
duplicating it, it's just a single line.

[Tobias Sargeant, 2017/01/12 14:27:56]

Done.

 
-bool RegisterJNI(JNIEnv* env) {
-  return RegisterLibraryLoaderEntryHook(env);
+  return RegisterLibraryLoaderEntryHook(base::android::AttachCurrentThread());
 }
 
-bool Init() {
+bool OnJNIOnLoadInit() {
   InitAtExitManager();
   JNIEnv* env = base::android::AttachCurrentThread();
   base::android::InitReplacementClassLoader(env,
                                             base::android::GetClassLoader(env));
   return true;
 }
 
-}  // namespace
-
-
-bool OnJNIOnLoadRegisterJNI(JavaVM* vm,
-                            std::vector<RegisterCallback> callbacks) {
-  base::android::InitVM(vm);
-  JNIEnv* env = base::android::AttachCurrentThread();
-
-  callbacks.push_back(base::Bind(&RegisterJNI));
-  for (std::vector<RegisterCallback>::reverse_iterator i =
-           callbacks.rbegin(); i != callbacks.rend(); ++i) {
-    if (!i->Run(env))
-      return false;
-  }
-  return true;
-}
-
-bool OnJNIOnLoadInit(std::vector<InitCallback> callbacks) {
-  callbacks.push_back(base::Bind(&Init));
-  for (std::vector<InitCallback>::reverse_iterator i =
-           callbacks.rbegin(); i != callbacks.rend(); ++i) {
-    if (!i->Run())
-      return false;
-  }
-  return true;
-}
-
 }  // namespace android
 }  // namespace base