Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2620303002: Refactor how UseCounter::SyntheticKeyframesInCompositedCSSAnimation is counted (Closed)
Patch Set: g cl set-commit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
index c385ff9cbf0fe832febf1d27b99b011eebb95d03..cf626f716c03afd12ae06fb383361f645c207cdb 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
@@ -172,35 +172,6 @@ static StringKeyframeEffectModel* createKeyframeEffectModel(
DCHECK(!keyframes.front()->offset());
DCHECK_EQ(keyframes.back()->offset(), 1);
- // This is used for use counting neutral keyframes running on the compositor.
- PropertySet allProperties;
- for (const auto& keyframe : keyframes) {
- for (const auto& property : keyframe->properties())
- allProperties.add(property.cssProperty());
- }
- const PropertyHandleSet& startKeyframeProperties =
- startKeyframe->properties();
- const PropertyHandleSet& endKeyframeProperties = endKeyframe->properties();
- bool missingStartValues =
- startKeyframeProperties.size() < allProperties.size();
- bool missingEndValues = endKeyframeProperties.size() < allProperties.size();
- if (missingStartValues || missingEndValues) {
- for (CSSPropertyID property : allProperties) {
- bool startNeedsValue =
- missingStartValues &&
- !startKeyframeProperties.contains(PropertyHandle(property));
- bool endNeedsValue =
- missingEndValues &&
- !endKeyframeProperties.contains(PropertyHandle(property));
- if (!startNeedsValue && !endNeedsValue)
- continue;
- if (CompositorAnimations::isCompositableProperty(property))
- UseCounter::count(
- elementForScoping->document(),
- UseCounter::SyntheticKeyframesInCompositedCSSAnimation);
- }
- }
-
StringKeyframeEffectModel* model =
StringKeyframeEffectModel::create(keyframes, &keyframes[0]->easing());
if (animationIndex > 0 && model->hasSyntheticKeyframes())
« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698