Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ui/views/controls/menu/menu_runner.h

Issue 2620203004: MenuRunner: Add comment to specify blocking behavior on MacViews. (Closed)
Patch Set: Address review. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_runner.h
diff --git a/ui/views/controls/menu/menu_runner.h b/ui/views/controls/menu/menu_runner.h
index f0adccf8e9d96e4846e1ae1ddcc5d2337aba51f8..63bb56a91010ca493ffdeee350abe8f1764f5d09 100644
--- a/ui/views/controls/menu/menu_runner.h
+++ b/ui/views/controls/menu/menu_runner.h
@@ -108,6 +108,8 @@ class VIEWS_EXPORT MenuRunner {
// Creates a new MenuRunner, which may use a native menu if available.
// |run_types| is a bitmask of RunTypes. If provided,
// |on_menu_closed_callback| is invoked when the menu is closed.
+ // Note that with a native menu (e.g. on Mac), the ASYNC flag in |run_types|
+ // may be ignored. See http://crbug.com/682544.
MenuRunner(ui::MenuModel* menu_model,
int32_t run_types,
const base::Closure& on_menu_closed_callback = base::Closure());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698