Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3749)

Unified Diff: chrome/browser/ssl/ssl_error_assistant.proto

Issue 2620203003: Add initial version of captive portal list checking. (Closed)
Patch Set: More tests and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_error_assistant.proto
diff --git a/chrome/browser/ssl/ssl_error_assistant.proto b/chrome/browser/ssl/ssl_error_assistant.proto
index ca64528e6513cbf1932f595146c457452f5947ee..ba05957cf11a3edc19dab714a9360b1eb65cd0a5 100644
--- a/chrome/browser/ssl/ssl_error_assistant.proto
+++ b/chrome/browser/ssl/ssl_error_assistant.proto
@@ -13,6 +13,8 @@ message CaptivePortalCert {
// with "sha256/" and encoded in base64 (same format as
// src/net/http/transport_security_state_static.pins)
// Example: sha256/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
+ //
+ // NOTE: Only leaf certs must be added here.
Ryan Sleevi 2017/02/01 22:06:06 When I read this outloud, it sounds weird, but it
meacer 2017/02/02 01:56:05 Technically intermediates and roots can also be ad
optional string sha256_hash = 1;
}

Powered by Google App Engine
This is Rietveld 408576698