Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4785)

Unified Diff: chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb

Issue 2620203003: Add initial version of captive portal list checking. (Closed)
Patch Set: More tests and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb
diff --git a/chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb b/chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb
index a6714bf5a0e95fdc9863c3fee4b5396ac3f87521..686dc829157eda49ade32e399a31f0696e53d462 100644
--- a/chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb
+++ b/chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb
@@ -2,17 +2,21 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# Placeholder for list of known certificates that are treated as captive
+# Placeholder list for SPKI hashes of certificates that are treated as captive
# portal certificates.
# TODO(crbug.com/640835): Populate this with full list.
version_id: 1
-# See chrome/browser/ssl/tls_error_assistant.proto for the full format.
+# See chrome/browser/ssl/ssl_error_assistant.proto for the full format.
captive_portal_cert {
-
# Sha256 hash of the certificate's public key. The fingerprint is prefixed
# with "sha256/" and encoded in base64 (same format as
# src/net/http/transport_security_state_static.pins)
sha256_hash: "sha256/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
Ryan Sleevi 2017/02/01 22:06:06 Is this an example? Or test data? I mean, it's tec
meacer 2017/02/02 01:56:05 It's magic test data and I thought we would publis
}
+
+# https://captive-portal.badssl.com leaf:
+captive_portal_cert {
+ sha256_hash: "sha256/fjZPHewEHTrMDX3I1ecEIeoy3WFxHyGplOLv28kIbtI="
+}

Powered by Google App Engine
This is Rietveld 408576698