Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2620203002: Fix ddc USAGE doc. (Closed)

Created:
3 years, 11 months ago by Bob Nystrom
Modified:
3 years, 11 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ddc USAGE doc. The only substantive change is adding the missing "--dart-sdk-summary=build" parameter to building the SDK. I went ahead and prettied up the Markdown too while I was at it. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/e5a45ffb5c205184da874c718ef9ea6d845c5cc2

Patch Set 1 #

Total comments: 6

Patch Set 2 : Revise a bit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M pkg/dev_compiler/USAGE.md View 1 1 chunk +54 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bob Nystrom
3 years, 11 months ago (2017-01-11 00:12:24 UTC) #2
vsm
https://codereview.chromium.org/2620203002/diff/1/pkg/dev_compiler/USAGE.md File pkg/dev_compiler/USAGE.md (right): https://codereview.chromium.org/2620203002/diff/1/pkg/dev_compiler/USAGE.md#newcode13 pkg/dev_compiler/USAGE.md:13: 1. Clone the [DDC repository](https://github.com/dart-lang/dev_compiler) and This should now ...
3 years, 11 months ago (2017-01-11 00:23:45 UTC) #3
Bob Nystrom
https://codereview.chromium.org/2620203002/diff/1/pkg/dev_compiler/USAGE.md File pkg/dev_compiler/USAGE.md (right): https://codereview.chromium.org/2620203002/diff/1/pkg/dev_compiler/USAGE.md#newcode13 pkg/dev_compiler/USAGE.md:13: 1. Clone the [DDC repository](https://github.com/dart-lang/dev_compiler) and On 2017/01/11 00:23:45, ...
3 years, 11 months ago (2017-01-11 00:55:16 UTC) #4
vsm
lgtm!
3 years, 11 months ago (2017-01-11 02:06:29 UTC) #5
Bob Nystrom
3 years, 11 months ago (2017-01-11 17:51:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e5a45ffb5c205184da874c718ef9ea6d845c5cc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698