Issue 2620183002: ConvertToARGB: Allows rotation on ARGB input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2620183002: ConvertToARGB: Allows rotation on ARGB input (Closed)

Created:
3 years, 11 months ago by jemoreira

Modified:
3 years, 11 months ago

Reviewers:
fbarchard1

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

More Reviews

Description

ConvertToARGB: Allows rotation on ARGB input BUG=libyuv:668 TEST=run unit tests R=fbarchard@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/cb115594082f2c1c4db2c067bd06a06681d74c1e

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -5 lines)			Patch
	M	source/convert_to_argb.cc	View		3 chunks	+12 lines, -5 lines	1 comment	Download
	M	unit_test/convert_test.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fbarchard1

https://codereview.chromium.org/2620183002/diff/1/source/convert_to_argb.cc File source/convert_to_argb.cc (right): https://codereview.chromium.org/2620183002/diff/1/source/convert_to_argb.cc#newcode105 source/convert_to_argb.cc:105: if (!need_buf && !rotation) { FYI for I420 version ...

3 years, 11 months ago (2017-01-11 19:42:17 UTC) #2

fbarchard1

3 years, 11 months ago (2017-01-11 22:38:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cb115594082f2c1c4db2c067bd06a06681d74c1e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages