Issue 262018: Revert sanity check; this doesn't actually work since UpdatePopupAppearance()...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262018: Revert sanity check; this doesn't actually work since UpdatePopupAppearance()... (Closed)

Created:
11 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert sanity check; this doesn't actually work since UpdatePopupAppearance() never removes child views (the popup quickly grows to its child limit and then stays there forever; we only show some of the children at a time though). BUG=20511 TEST=none TBR=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28361

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ok

Expand Messages | Collapse Messages