[Bindings] Code cleanup: Early return if funtime enabled interface is false

third_party/WebKit/Source/bindings/scripts/v8_utilities.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 94 matching lines @@
     """Uncapitalizes first letter or initial acronym (used in method names).
 
     E.g., 'SetURL' becomes 'setURL', but 'URLFoo' becomes 'urlFoo'.
     """
     for acronym in ACRONYMS:
         if name.startswith(acronym):
             return name.replace(acronym, acronym.lower())
     return name[0].lower() + name[1:]
 
 
+def runtime_enabled_function(name):

[Yuki, 2017/01/13 02:38:37]

I'm uneasy with this name because "runtime enabled function" reads a function
(or function name) which can be enabled at runtime.

This function is a predictor.  So, I'd recommend "is_runtime_enabled" instead.

  def is_runtime_enabled(feature_name):

[peria, 2017/01/13 05:54:26]

I'll make a follow up CL.
But I think the prefix "is_" is not good for functions which return strings.

+    """Returns a function call of a runtime enabled feature."""
+    return 'RuntimeEnabledFeatures::%sEnabled()' % uncapitalize(name)
+
+
 def unique_by(dict_list, key):
     """Returns elements from a list of dictionaries with unique values for the named key."""
     keys_seen = set()
     filtered_list = []
     for item in dict_list:
         if item.get(key) not in keys_seen:
             filtered_list.append(item)
             keys_seen.add(item.get(key))
     return filtered_list
 
@@ skipping 162 matching lines @@
         return len(self.exposures)
 
     def __iter__(self):
         return self.exposures.__iter__()
 
     @staticmethod
     def _code(exposure):
         exposed = ('executionContext->%s()' %
                    EXPOSED_EXECUTION_CONTEXT_METHOD[exposure.exposed])
         if exposure.runtime_enabled is not None:
-            runtime_enabled = ('RuntimeEnabledFeatures::%sEnabled()' %
-                               uncapitalize(exposure.runtime_enabled))
+            runtime_enabled = (runtime_enabled_function(exposure.runtime_enabled))
             return '({0} && {1})'.format(exposed, runtime_enabled)
         return exposed
 
     def code(self):
         if len(self.exposures) == 0:
             return None
         # We use sorted here to deflake output.
         return ' || '.join(sorted(self._code(e) for e in self.exposures))
 
 
@@ skipping 332 matching lines @@
         return None
 
 
 IdlInterface.legacy_caller = property(legacy_caller)
 IdlInterface.indexed_property_getter = property(indexed_property_getter)
 IdlInterface.indexed_property_setter = property(indexed_property_setter)
 IdlInterface.indexed_property_deleter = property(indexed_property_deleter)
 IdlInterface.named_property_getter = property(named_property_getter)
 IdlInterface.named_property_setter = property(named_property_setter)
 IdlInterface.named_property_deleter = property(named_property_deleter)