Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: ash/common/wm/window_positioning_utils.cc

Issue 2620153003: Folds WmRootWindowController into RootWindowController (Closed)
Patch Set: merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/wm/window_cycle_list.cc ('k') | ash/common/wm/wm_screen_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/wm/window_positioning_utils.h" 5 #include "ash/common/wm/window_positioning_utils.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ash/common/wm/system_modal_container_layout_manager.h" 9 #include "ash/common/wm/system_modal_container_layout_manager.h"
10 #include "ash/common/wm/window_state.h" 10 #include "ash/common/wm/window_state.h"
11 #include "ash/common/wm/wm_event.h" 11 #include "ash/common/wm/wm_event.h"
12 #include "ash/common/wm/wm_screen_util.h" 12 #include "ash/common/wm/wm_screen_util.h"
13 #include "ash/common/wm_lookup.h" 13 #include "ash/common/wm_lookup.h"
14 #include "ash/common/wm_root_window_controller.h"
15 #include "ash/common/wm_shell.h" 14 #include "ash/common/wm_shell.h"
16 #include "ash/common/wm_window.h" 15 #include "ash/common/wm_window.h"
17 #include "ash/common/wm_window_tracker.h" 16 #include "ash/common/wm_window_tracker.h"
17 #include "ash/root_window_controller.h"
18 #include "ui/display/display.h" 18 #include "ui/display/display.h"
19 #include "ui/display/types/display_constants.h" 19 #include "ui/display/types/display_constants.h"
20 #include "ui/gfx/geometry/rect.h" 20 #include "ui/gfx/geometry/rect.h"
21 #include "ui/gfx/geometry/size.h" 21 #include "ui/gfx/geometry/size.h"
22 22
23 namespace ash { 23 namespace ash {
24 namespace wm { 24 namespace wm {
25 25
26 namespace { 26 namespace {
27 27
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 const display::Display& display) { 131 const display::Display& display) {
132 DCHECK_NE(display::kInvalidDisplayId, display.id()); 132 DCHECK_NE(display::kInvalidDisplayId, display.id());
133 // Don't move a window to other root window if: 133 // Don't move a window to other root window if:
134 // a) the window is a transient window. It moves when its 134 // a) the window is a transient window. It moves when its
135 // transient parent moves. 135 // transient parent moves.
136 // b) if the window or its ancestor has IsLockedToRoot(). It's intentionally 136 // b) if the window or its ancestor has IsLockedToRoot(). It's intentionally
137 // kept in the same root window even if the bounds is outside of the 137 // kept in the same root window even if the bounds is outside of the
138 // display. 138 // display.
139 if (!window->GetTransientParent() && 139 if (!window->GetTransientParent() &&
140 !IsWindowOrAncestorLockedToRoot(window)) { 140 !IsWindowOrAncestorLockedToRoot(window)) {
141 WmRootWindowController* dst_root_window_controller = 141 RootWindowController* dst_root_window_controller =
142 WmLookup::Get()->GetRootWindowControllerWithDisplayId(display.id()); 142 WmLookup::Get()->GetRootWindowControllerWithDisplayId(display.id());
143 DCHECK(dst_root_window_controller); 143 DCHECK(dst_root_window_controller);
144 WmWindow* dst_root = dst_root_window_controller->GetWindow(); 144 WmWindow* dst_root = dst_root_window_controller->GetWindow();
145 DCHECK(dst_root); 145 DCHECK(dst_root);
146 WmWindow* dst_container = nullptr; 146 WmWindow* dst_container = nullptr;
147 if (dst_root != window->GetRootWindow()) { 147 if (dst_root != window->GetRootWindow()) {
148 int container_id = window->GetParent()->GetShellWindowId(); 148 int container_id = window->GetParent()->GetShellWindowId();
149 // All containers that uses screen coordinates must have valid window ids. 149 // All containers that uses screen coordinates must have valid window ids.
150 DCHECK_GE(container_id, 0); 150 DCHECK_GE(container_id, 0);
151 // Don't move modal background. 151 // Don't move modal background.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 193 }
194 gfx::Point origin(bounds_in_screen.origin()); 194 gfx::Point origin(bounds_in_screen.origin());
195 const gfx::Point display_origin = 195 const gfx::Point display_origin =
196 window->GetDisplayNearestWindow().bounds().origin(); 196 window->GetDisplayNearestWindow().bounds().origin();
197 origin.Offset(-display_origin.x(), -display_origin.y()); 197 origin.Offset(-display_origin.x(), -display_origin.y());
198 window->SetBounds(gfx::Rect(origin, bounds_in_screen.size())); 198 window->SetBounds(gfx::Rect(origin, bounds_in_screen.size()));
199 } 199 }
200 200
201 } // namespace wm 201 } // namespace wm
202 } // namespace ash 202 } // namespace ash
OLDNEW
« no previous file with comments | « ash/common/wm/window_cycle_list.cc ('k') | ash/common/wm/wm_screen_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698